[#32990] - [4][ReleaseBlocker] Users lose user groups after password reset via frontend
- Fixed in Code Base
- 4 Apr 2021
- Medium
- Build: 4.0-dev
- # 32990
- Diff
- PhilETaylor:usergroups
User tests: Successful: 2 brianteeman, joomdonation Unsuccessful: 0
Pull Request for Issue #32981 .
Summary of Changes
The proposed "Quick fix" implemented to resolve this issue.
Testing Instructions
If a user attempt to use the "forgot password" function at the frontend, the assigned user groups are lost.
Actual result BEFORE applying this Pull Request
Some groups assigned to a user are lost on saving
Expected result AFTER applying this Pull Request
User retains group membership
Documentation Changes Required
none
References
#32981 (comment)
joomla-framework/database#247
joomla-framework/database#211 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item
Yes, this solves the issue but we should not have call array_values here. Making this change is no hurt but I'm worry that we might get similar logical error like this in other places if the change in database package is not accepted.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32990.
| Status | Pending | ⇒ | Ready to Commit |
RTC because it has 2 good tests.
If there will be a fix in the framework's database package, it needs to check and maybe clean up the CMS code anyway by array_value calls which become unnecessary after such a change.
It's not clear if such a fix in the framework will be made, and if it's made, it might take some time until a new 2.0 beta release of the framework package is made and fetched into the CMS, so for the mean time this fix here is needed in my opinion.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32990.
Yes, that's the reason I gave it a successful test.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-04 08:38:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
|
||
Cheers guys. Will let Niels decide on the framework PR
Thanks both for testing, and thanks for the quick merge! One less release blocker!
I have tested this item✅ successfully on 4e3205d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32990.