[#32980] - [4.0] Module Custom: remove inline style
- Fixed in Code Base
- 4 Apr 2021
- Medium
- Build: 4.0-dev
- # 32980
- Diff
- Fedik:m-custom-bg
User tests: Successful: Unsuccessful:
Summary of Changes
this changes how background added to the Custom module, to avoid conflict with CSP rules.
Testing Instructions
Apply patch.
Click "Enable" in CSP component.
Create a custom module with background, and some content.
Check the module rendering.
Actual result BEFORE applying this Pull Request
Background not visible,
in browser console CSP related error.
Expected result AFTER applying this Pull Request
Background visible,
in browser console no CSP related error.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
Apply path.
What exactly do you mean by this? Patch Tester?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32980.
What exactly do you mean by this? Patch Tester?
Sorry that was typo ;)
Yes, I meant Patch not Path . Just apply the changes.
Actual result BEFORE applying this Pull Request
Background not visible,
in browser console CSP related error.
The background is really visible. NOK
I can confirm that there is in the browser console a CSP related error. OK
Is it ok that it does not have the query string?
Before PR:
background-image: url(/joomla-cms-4.0-dev/images/banners/banner.jpg?joomla_image_width=1140&joomla_image_height=600)
After PR:
background-image: url("/joomla-cms-4.0-dev/images/banners/banner.jpg")
yes, the query does not do anything, it something that comes from mediamanager,
The image has repeat-x, repeat-y. Is this intended?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32980.
The image has repeat-x, repeat-y. Is this intended?
yeap, this is default behavior of this module, since this feature exists
if you do test without CSP you will see that "before and after" looks the same
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32980.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32980.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-04 16:35:52 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
Did I miss something? Before and after this PR I get to see the following message in the browser in the frontend site.
Did I miss something?
yeap, CSP will not work on localhost, need extra configuration or just use a virtual domain
I have tested this item✅ successfully on 4a14fe1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32980.