?
avatar sandramay0905
sandramay0905
3 Apr 2021

What needs to be fixed

In an multilanguage Article hover on an also available Language:

Bildschirmfoto 2021-04-03 um 09 59 50

Why this should be fixed

Hard to read

How would you fix it

More Difference between Letters and Background.

Side Effects expected

Don't know.

System Information

grafik

avatar sandramay0905 sandramay0905 - open - 3 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Apr 2021
avatar sandramay0905 sandramay0905 - change - 3 Apr 2021
The description was changed
avatar sandramay0905 sandramay0905 - edited - 3 Apr 2021
avatar infograf768
infograf768 - comment - 3 Apr 2021

Confirmed. So used to use flags I guess nobody tested using lang code there.

avatar infograf768
infograf768 - comment - 3 Apr 2021

First aspect to change is to get this
Screen Shot 2021-04-03 at 11 53 58

This to let choose when we have languages for different countries: de-DE, de-AT, etc. and correct useless whitespace between badges.

Code would be

<dd class="association">
	<span class="icon-globe icon-fw" aria-hidden="true"></span>
	<?php echo Text::_('JASSOCIATIONS'); ?>
	<?php foreach ($associations as $association) : ?>
		<?php if ($displayData['item']->params->get('flags', 1) && $association['language']->image) : ?>
			<?php $flag = HTMLHelper::_('image', 'mod_languages/' . $association['language']->image . '.gif', $association['language']->title_native, array('title' => $association['language']->title_native), true); ?>
			<a href="<?php echo Route::_($association['item']); ?>"><?php echo $flag; ?></a>
		<?php else : ?>
			<?php $class = 'badge bg-secondary badge-' . strtolower($association['language']->lang_code); ?>
			<a class="<?php echo $class; ?>" title="<?php echo $association['language']->title_native; ?>" href="<?php echo Route::_($association['item']); ?>"><?php echo $association['language']->lang_code; ?></a>
		<?php endif; ?>
	<?php endforeach; ?>
</dd>
<?php endif; ?>

then we have an issue with the hover colour. Remark that in backend managers we have no hover.
Looking at it now.

avatar infograf768
infograf768 - comment - 3 Apr 2021

What do you think about this?

assoc_front

EDIT: same modifications for list category

assoc_front-list

avatar brianteeman
brianteeman - comment - 3 Apr 2021

remark that there is no "on-hover" when it is flags

avatar sandramay0905
sandramay0905 - comment - 4 Apr 2021

What do you think about this?

Looks fine for me.

avatar brianteeman
brianteeman - comment - 4 Apr 2021

According to the bootstrap 5 documentation badges should no longer have focus or hover styles for links. https://getbootstrap.com/docs/5.0/components/badge/

avatar infograf768
infograf768 - comment - 4 Apr 2021

the PR (to come) will change badges to buttons.

avatar infograf768 infograf768 - change - 4 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-04 09:17:36
Closed_By infograf768
avatar infograf768 infograf768 - close - 4 Apr 2021
avatar infograf768
infograf768 - comment - 4 Apr 2021

See #32992 closing

Add a Comment

Login with GitHub to post a comment