Feeling Lucky
?
?
[#3297] - System Tests, Adding Missing Input Fields
- Closed
- 27 Mar 2014
- Medium
- Build: staging
- # 3297
- Diff
- kshitijSharma2014:Branch1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
javigomez
- comment
- 17 Mar 2014
adding @dextercowley in CC so we can get his advise too.
dextercowley
- comment
- 17 Mar 2014
I ran the getAllInputFields_ScreenDisplayed_EqualExpected() test in webdriver/tests/content/ArticleManager0001Test.php with the change applied and the test ran successfully. So I think this is ready to merge. Thanks!
javigomez
- comment
- 27 Mar 2014
Tested, worked to me too:
phpunit content/ArticleManager0001Test.php
PHPUnit 3.7.29 by Sebastian Bergmann.
........
Time: 4.12 minutes, Memory: 6.25Mb
OK (8 tests, 243 assertions)
Merging.
Thanks @puneet0191 and @dextercowley for testing. And thanks very much and congratulations @kshitijSharma2014 for your first pull being merged ^_^
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-27 19:26:49 |
| Labels | |||
Bakual
-
Seems good!, you have to look for similar changes in lot of other pages as well..but that is good for a start! I think we can merge it @javiergomez