Joomla! Issue Tracker | Joomla! CMS #32957 - [4.0] None minified scripts are loaded

Closed
9 Aug 2021
Medium
Build: staging
# 32957

laoneo
1 Apr 2021

Steps to reproduce the issue

Open the back end.
Open /administrator/index.php?option=com_config.
Set debug mode to false in the Joomla configuration.
Save.
Open Network tab in dev tools.

Expected result

Only minified scripts are loaded.

Actual result

Carousel is loaded none minified and dom.js is loaded in none minified version and minified.

System information (as much as possible)

Latest 4.0 dev.

Additional comments

Not sure if this is related to #32429 and #32300.

Pinging here @dgrammatiko.

laoneo - open - 1 Apr 2021

joomla-cms-bot - change - 1 Apr 2021

Labels

Added: ?

joomla-cms-bot - labeled - 1 Apr 2021

laoneo - change - 1 Apr 2021

The description was changed

laoneo - edited - 1 Apr 2021

dgrammatiko - comment - 1 Apr 2021

The code seems ok here:

joomla-cms/build/build-modules-js/javascript/build-bootstrap-js.es6.js

Lines 19 to 24 in db414e7

    
           const createMinified = async (file) => { 
        
             const initial = await readFile(resolve(outputFolder, file), { encoding: 'utf8' }); 
        
             const mini = await minify(initial.replace('./popper.js', `./popper.min.js?${getCurrentUnixTime}`).replace('./dom.js', `./dom.min.js?${getCurrentUnixTime}`), { sourceMap: false, format: { comments: false } }); 
        
             await writeFile(resolve(outputFolder, file), initial.replace('./popper.js', `./popper.js?${getCurrentUnixTime}`).replace('./dom.js', `./dom.js?${getCurrentUnixTime}`), { encoding: 'utf8' }); 
        
             await writeFile(resolve(outputFolder, file.replace('.js', '.min.js')), mini.code, { encoding: 'utf8' }); 
        
           };

I can't replicate it with the default scripts on the page (the carousel is not in that view). Did you use HTMLHelper to load the scripts (eg using the boostrap.carousel helper: https://gist.github.com/dgrammatiko/efb3de4aa7cab4813a244f93f73cc0fd)?

brianteeman - comment - 2 Aug 2021

Is this still an issue for you as I cannot replicate it

laoneo - change - 9 Aug 2021

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2021-08-09 06:06:18
Closed_By		⇒	laoneo
Labels	Added: ? Removed: ?

laoneo - close - 9 Aug 2021

laoneo - comment - 9 Aug 2021

Nope, issue is gone along the way.

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#32957] - [4.0] None minified scripts are loaded