? Pending

User tests: Successful: Unsuccessful:

avatar Piyussshh
Piyussshh
1 Apr 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar Piyussshh Piyussshh - open - 1 Apr 2021
avatar Piyussshh Piyussshh - change - 1 Apr 2021
Status New Pending
avatar richard67
richard67 - comment - 1 Apr 2021

@Piyussshh Please fill in the missing information in the description of your pull request, i.e. add the necessary text below the headings "Summary of Changes", "Testing Instructions" and so on. We don't have these headings without reason in our template for new pull requests.

And please give your pull request a meaningful title.

Finally, at the top of the description of your pull request you can see a line "Pull Request for Issue # .". Please complete the issue number so people know which issue your pull request shall solve. I assume it's issue #32929 , but that's just my guess.

Thanks in advance.

avatar brianteeman
brianteeman - comment - 1 Apr 2021

Just close it. It refers to an issue of mine but its nt the correct solution and its to the wrong branch

avatar richard67
richard67 - comment - 1 Apr 2021

@brianteeman Ouch ... I did not notice the wrong branch. I need more coffee (or better one).

avatar richard67
richard67 - comment - 1 Apr 2021

@Piyussshh Thank you for your contribution. Unfortunately it is wrong because:

  1. Your pull request (PR) is made for the staging branch, but there the files exist where they should be. The issue was for the 4.0-dev branch.
  2. In the comments in issue #32929 you can see that the problem is not the files missing, it's the (S)CSS to be removed.

Please don't be disappointed. It can happen that a PR is wrong. Happened to me too once.

avatar richard67 richard67 - change - 1 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-01 12:08:01
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 1 Apr 2021
avatar brianteeman
brianteeman - comment - 1 Apr 2021

@richard67 the images are also a mix of formats, completely the wrong size and sourced from ???

avatar richard67
richard67 - comment - 1 Apr 2021

Yes, that too.

Add a Comment

Login with GitHub to post a comment