[#32951] - [4.0] Atum badge borders
- Fixed in Code Base
- 1 Apr 2021
- Medium
- Build: 4.0-dev
- # 32951
- Diff
- brianteeman:badge
User tests: Successful: Unsuccessful:
Some of the badges are set to have a border that is a color lighter than the badge text. Unfortunately that doesn't work if the text is white you get a white border.
All the badges need to have a visible border otherwise the badges will appear visually to be of different sizes.
This PR changes the border of the two existing white bordered badges to use the same shade of the dark text that the bg-info badge uses.
Testers dont forget to run npm to rebuild the css
The easies way to to check this would be in the article list after enabling the voting plugin
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
Wouldn't it better to remove the border? Why override Bootsrap badges when they look the same except for the border?
I have tested this item
## Before:
After:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.
Wouldn't it better to remove the border? Why override Bootsrap badges when they look the same except for the border?
I am not redesigning the template I am just fixing an obvious bug. From the code we can see that the intention was clearly to have a border but it ended up invisible
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-01 17:17:42 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks.
thanks
I have tested this item✅ successfully on 41fb0e8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32951.