? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
31 Mar 2021

Pull Request for Issue #32941

Summary of Changes

Allow period in database name for mysql - this is allowed by the documentation of Mysql 5.6 as periods are allowed in quoted identifiers and Joomla quotes the db name on use

This fixes a b\c break with Joomla 3 as per commentary in #32941

Testing Instructions

Attempt to install Joomla 4 with a database name with a period in it such as joomla.test4

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

You can install and use Joomla 4 with no issues with a database name with a period in it.

Documentation Changes Required

note: only changed mysql, other db platforms might need a review too.

avatar PhilETaylor PhilETaylor - open - 31 Mar 2021
avatar PhilETaylor PhilETaylor - change - 31 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2021
Category Installation Language & Strings Libraries
avatar progreccor
progreccor - comment - 31 Mar 2021

I have tested and it is work as I expected.
Good!

avatar richard67 richard67 - alter_testresult - 31 Mar 2021 - progreccor: Tested successfully
avatar richard67
richard67 - comment - 31 Mar 2021

I've marked the test result for @progreccor .

avatar b2z b2z - test_item - 31 Mar 2021 - Tested successfully
avatar b2z
b2z - comment - 31 Mar 2021

I have tested this item successfully on 6d43d8e

Tested. I was able to install J4 to DB with the name joomla.test4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32949.

avatar richard67 richard67 - change - 31 Mar 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 31 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32949.

avatar PhilETaylor
PhilETaylor - comment - 31 Mar 2021

Thanks all for testing and getting this RTC so quickly. Fingers crossed it makes it into Joomla 4 now.

avatar wilsonge
wilsonge - comment - 1 Apr 2021

We're not accepting new features in.... just kidding - thanks merged!

avatar wilsonge wilsonge - change - 1 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-01 12:52:52
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Apr 2021
avatar wilsonge wilsonge - merge - 1 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 1 Apr 2021

Thanks

avatar progreccor
progreccor - comment - 1 Apr 2021

thanks!

Add a Comment

Login with GitHub to post a comment