[#32945] - [4.0] Use votelist field type for "Voting" option fields
- Fixed in Code Base
- 1 Apr 2021
- Medium
- Build: 4.0-dev
- # 32945
- Diff
- richard67:4.0-dev-use-votelist-fields
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Continue the work of PR #31381 for other places where we have "Voting" option fields, i.e. use the "vote list" field type for these fields so they are not shown when the vote plugin is disabled, and fix a few code style issues in the XML files touched.
Thanks @infograf768 for the initial work for this PR.
Testing Instructions
-
Without the patch of this PR applied, make sure that the "Content - Vote" plugin is disabled.
-
In Global Configuration, tab "Site", set "Frontend Editing" to "Modules & Menus".
-
In backend, create a new or edit an existing item of the following types, and check in tab "Options" of the form in section "Options" if there is a field "Voting" shown:
- Article
- Menu item of type "Single Article"
- Menu item of type "Category Blog"
- Menu item of type "Category List"
- Menu item of type "Featured Articles"
- Menu item of type "List All Categories ..."
Result: See section "Actual result BEFORE applying this Pull Request", the "Voting" field is shown.
- Login to frontend and repeat the previous step in frontend editing for the menu items.
Result: See section "Actual result BEFORE applying this Pull Request", the "Voting" field is shown.
-
Apply the patch of this PR.
-
Repeat steps 3 and 4.
Result: See section "Expected result AFTER applying this Pull Request", the "Voting" field is not shown.
-
Enable the "Content - Vote" plugin.
-
Repeat again steps 3 and 4.
Result: The "Voting" field is shown.
Actual result BEFORE applying this Pull Request
The "Voting" field is shown regardless if the "Content - Vote" plugin is enabled or not in the following forms in tab "Options", section "Options":
- Article edit in backend
- Menu item edit for menu item types "Single Article", "Category Blog", "Category List", "Featured Articles" and "List All Categories ..." (backend and frontend).
Expected result AFTER applying this Pull Request
The "Voting" field in the forms mentioned above in section "Actual result BEFORE applying this Pull Request" is only shown if the "Content - Vote" plugin is enabled.
Documentation Changes Required
Possibly docs need to be updated to mention that the "Voting" fields handled by this PR are not shown when the "Content - Vote" plugin is disabled.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
I tested and it mostly works but I have some observations and questions:
In the backend some forms have Voting immediately before Hits - easy to spot. In others Read More Link and Title with Read More come between - not so easy to spot. Could the order be looked at?
What happens when a form is saved without the plugin enabled: Enable plugin, in Edit form set Voting to Show and save; disable plugin, reload Edit form and save; enable plugin, reload - Voting has gone back to default Use Global (Hide). So we need some comment in the documentation.
In the front end I do not have an Oprions tab (my fault?) and the Menu item edit links open the Administrator interface.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32945.
I have tested this item
I tested and it mostly works but I have some observations and questions:
In the backend some forms have Voting immediately before Hits - easy to spot. In others Read More Link and Title with Read More come between - not so easy to spot. Could the order be looked at?
What happens when a form is saved without the plugin enabled: Enable plugin, in Edit form set Voting to Show and save; disable plugin, reload Edit form and save; enable plugin, reload - Voting has gone back to default Use Global (Hide). So we need some comment in the documentation.
In the front end I do not have an Oprions tab (my fault?) and the Menu item edit links open the Administrator interface.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32945.
In the backend some forms have Voting immediately before Hits - easy to spot. In others
Read More LinkandTitle with Read Morecome between - not so easy to spot. Could the order be looked at?
Sure, but that's not related to this PR, I think. I don't know right now if we have already an issue for that or not. If not, feel free to open one.
What happens when a form is saved without the plugin enabled: Enable plugin, in Edit form set Voting to Show and save; disable plugin, reload Edit form and save; enable plugin, reload - Voting has gone back to default
Use Global (Hide). So we need some comment in the documentation.
That's how I expect it to work.
In the front end I do not have an Oprions tab (my fault?)
No, not your fault. That's why my test for frontend doesn't check the edit article form.
and the Menu item edit links open the Administrator interface.
Right. But I wanted to be sure it still works.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32945.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-01 12:54:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks for tests and merge.
I have tested this item✅ successfully on c76b376
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32945.