[#32932] - [4.0] Fix restore category/article from first version in version history
- Fixed in Code Base
- 9 Apr 2021
- Medium
- Build: 4.0-dev
- # 32932
- Diff
- joomdonation:fix_restore_category_article_from_history
User tests: Successful: Unsuccessful:
Pull Request for Issue #32890.
Summary of Changes
Load data from current version before replacing it with data from history to avoid error if there are some required keys are missing in the history data. See #32890 to understand more about the issue.
Testing Instructions
- See #32890 , confirm the issue
- Apply patch, confirm that the issue is sorted . Please test by both restore category and article from it's first version.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Im not sure this is the correct fix, as these values do exist at some point, but if it works it works :)
I tried changing a Category option as well as adding lines of text to the description. And I tried on a separate installation I use for other testing. In neither case do I get a list of Versions. I looked in the #__history table - there are entries for the article content but no entries for the category. So there must be some way to enable history versions in categories that I have missed,
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.
I'm not sure this is the correct fix, as these values do exist at some point, but if it works it works :)
?
From what I see, at least for article, when you save a new article, data for ordering is not available and it is set to 0 (0 is default value for ordering field)
I believe the same thing happens for category on first save (first version). Some data is not available on saving process (at least when the system tries to save version history), so it makes sense to set default value like in the propose code.
@ceford Are you creating category for article? If not, please do so. Also, do you see Versions button in the toolbar while editing that category?
I use default Joomla 4 installation, and version history is enabled by default, so I don't know why it is not available for your test site.
Content -> Categories -> + then follow instructions. No Toolbar Versions label before first save. Same occurs for Contact -> Categories -> New. This is a Multi-Lingual test site! I am using Eclipse with Git to Pull and Merge the latest changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.
Column 'created_by_alias' cannot be null
Installed Testing Sample Data.
Edit Popular Tags article.
Click Versions button.
Click the only entry.
Click Restore button.
Column 'cid' cannot be null
Edit a banner.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.
I've restored the previous test result in the issue tracker since the change which has invalidated the test was just a change in a comment.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.
This solution looks much better than the initial one! Great work!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-09 17:01:29 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
For me this works fine for Articles but for Categories I do not get a list of Versions to choose from. Is there some setting I have missed?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32932.