Feeling Lucky
?
?
[#32899] - [4][com_finder] Remove redundant sql query from running twice
- Fixed in Code Base
- 29 Mar 2021
- Medium
- Build: 4.0-dev
- # 32899
- Diff
- PhilETaylor:patch-89
User tests: Successful: Unsuccessful:
Summary of Changes
This is clearly wrong on code review.
Testing Instructions
Enable debug mode
visit https://example.com/administrator/index.php?option=com_finder&view=index
inspect the db queries run
Actual result BEFORE applying this Pull Request
The following SQL query is run twice, once on execute and once on loadResult
SELECT COUNT(link_id)
FROM `jos_finder_links`
Expected result AFTER applying this Pull Request
The following SQL query is run once, on loadResult
SELECT COUNT(link_id)
FROM `jos_finder_links`Page loads 2.53ms faster ;-)
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
ceford
- comment
- 29 Mar 2021
I have tested this item
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-29 19:53:53 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 29 Mar 2021
Thanks!
I have tested this item✅ successfully on ab2c464
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32899.