Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
28 Mar 2021

Pull Request for Issue # .

Summary of Changes

One view to rule them all.

  • Removes the 2 different entry layouts for the templates (template, style)
  • Introduces the styling from Konshu template
  • Fixes all the menus
  • Brings the install logic from Konshu

This PR largely is the adoption of the work that was done by @kawshar and his team in their backend template. So all the kudos should go to them, I'm just bringing their code to the current branch (with their permissions)

Testing Instructions

This is part of a wider rewrite of com_templates, probably has some a11y issues but should be functionally on par with the previous state (actually should be better as everything is one click away)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screenshot 2021-03-28 at 17 39 31

Screenshot 2021-03-28 at 17 39 48

Screenshot 2021-03-28 at 17 43 45

Install template with one click
Screenshot 2021-03-28 at 19 00 28

Screenshot 2021-03-28 at 19 00 40

Documentation Changes Required

@brianteeman can you review the a11y and the strings here?

avatar dgrammatiko dgrammatiko - open - 28 Mar 2021
avatar dgrammatiko dgrammatiko - change - 28 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Administration com_menus com_templates Language & Strings Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 28 Mar 2021
Labels Added: ? NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 28 Mar 2021

looks good. will test properly later

avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Administration com_menus com_templates Language & Strings Repository NPM Change Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript
avatar dgrammatiko dgrammatiko - change - 28 Mar 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 28 Mar 2021
avatar Quy
Quy - comment - 28 Mar 2021

Go to Home Dashboard.
Click Cog icon under Site and select Edit.
Remove Template Code Icon option.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2021
Category Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript Administration com_menus com_templates Language & Strings Modules Repository NPM Change JavaScript
avatar dgrammatiko
dgrammatiko - comment - 28 Mar 2021

@Quy done, thanks, good catch

avatar Bond97
Bond97 - comment - 28 Mar 2021

I dont know, should I create new issue, but I write my suggestion in this PR.

When I upgrade Joomla 4.0.0 beta8-dev to new daily version (check updates and reinstall Joomla core files), sometimes there is a notification "%number% overriden files changed" and in this frame text changed to "%number% overrides to check".
image

I go to administrator/index.php?option=com_templates&view=templates, in override files column show yellow "changes found". Usually it happens with helixultimate template (new 2.0.0 beta version). With cassiopeia that notification not showing.

My suggestion: show, which of files has changed or overriden. Maybe it be useful for @dgrammatiko attempt to rewrite com_template.

Or it's unnecessary function?

avatar brianteeman
brianteeman - comment - 28 Mar 2021

The main change I would make is the way that multiple styles of the same template are handled.

In khansu they were all listed together but in this version they duplicate all the other template stuff.

image

Plus the preview is for the style not the template. So I would be looking to make the layout more like
image

avatar brianteeman
brianteeman - comment - 28 Mar 2021

My suggestion: show, which of files has changed or overriden.

And if there are 25 changed files?

avatar dgrammatiko
dgrammatiko - comment - 28 Mar 2021

Plus the preview is for the style not the template. So I would be looking to make the layout more like

That was easy

In khansu they were all listed together but in this version they duplicate all the other template stuff.

This needs some query tweaking

avatar Bond97
Bond97 - comment - 28 Mar 2021

@brianteeman I don't know about that, it's just my suggestion :) I think, when number of changed files are more than 15-20, it's hard to read list all of them.

Maybe it's unnesessary function.

avatar brianteeman
brianteeman - comment - 28 Mar 2021

@dgrammatiko I think you also need to rethink the actions menu - it might not even be needed - so that its clear if the action is for the style or the template

avatar ceford
ceford - comment - 29 Mar 2021

Looks good. The Title bar might be Templates: Site or Templates Administrator as required. I think the default template should no be 'deletable'. And I guess the double icons for Info and Preview will get fixed. The first screen grab shows a different side menu order - I assume that is a user choice and not an intended default (no need to answer that unless it is).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32896.

avatar kawshar
kawshar - comment - 29 Mar 2021

Why don't you use the exact UX that we proposed?

avatar dgrammatiko
dgrammatiko - comment - 29 Mar 2021

@kawshar I think I kept it almost intact (apart from changing some elements for a11y and using the existing styling, not going to restyle everything here)

Screenshot 2021-03-29 at 17 13 57
Screenshot 2021-03-29 at 17 14 44

avatar ceford
ceford - comment - 29 Mar 2021

Another thought: I wonder if Edit Files and Edit Style might be simplified to Files and Options? For me the word Style leads me to expect to do something with css but that is done by editing user.css.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32896.

avatar brianteeman
brianteeman - comment - 30 Mar 2021

@ceford that does indeed make sense when you only have one style. As soon as you have multiple styles it becomes more confusing.

avatar ghazal ghazal - test_item - 31 Mar 2021 - Tested successfully
avatar ghazal
ghazal - comment - 31 Mar 2021

I have tested this item successfully on 4f5c35d

Nice changes.
I really hope it will be accepted.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32896.

avatar dgrammatiko
dgrammatiko - comment - 31 Mar 2021

@ghazal thanks for testing this but it's still a draft, needs some more work before it gets to the testing stage...

avatar brianteeman
brianteeman - comment - 1 Apr 2021

The quickicon doesnt display. I have made a pr to your branch to fix that
dgrammatiko#1

avatar astridx
astridx - comment - 2 Apr 2021

I have just tested this branch. Thank you for this.

Can I still make a copy of a template in this PR? I can't find the button.

And then I noticed this:

  • Go to Home Dashboard.
  • Click Overrides are up to date
  • You get an 500er Error.

Home Dashboard template Administration

Error 500

avatar dgrammatiko
dgrammatiko - comment - 2 Apr 2021

Can I still make a copy of a template in this PR? I can't find the button.

Only for Legacy templates. The new mode - (able for child templates) won't have the duplicate functionality because they don't need it, you can have child templates instead.

Click Overrides are up to date

I'll have to check why it's broken, bet I have to say that the overrides checks are very badly implemented, maybe I will redo them or if it is too messy will have to ask for removal and reintroduce them properly in 4.1 or later

avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2021
Category Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript Modules Administration com_admin com_content com_finder com_installer com_languages com_login JavaScript com_media NPM Change com_menus com_modules com_templates
avatar dgrammatiko
dgrammatiko - comment - 2 Apr 2021

Ok an update here, there's still a bit more work for this view but I want to share this as some of the comments are already addressed or I'm currently working on them:

The template card now looks like this (addressing @brianteeman 's comment of not having multiple cards per template, just to mention that the khansu had one card per style) :

Screenshot 2021-04-02 at 16 20 58

Screenshot 2021-04-02 at 16 21 06

Screenshot 2021-04-02 at 16 21 14

Not all the actions are yet wired to the backend and also the child templates are not yet properly in the loop. In sort still WIP...

avatar dgrammatiko dgrammatiko - change - 2 Apr 2021
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 2 Apr 2021

Looking good. I would keep edit files separate from the styles actions. Otherwise keep up the great work

avatar dgrammatiko
dgrammatiko - comment - 2 Apr 2021

Looking good. I would keep edit files separate from the styles actions

Yeah, this together with the template delete should be on the header of the card (I guess)

avatar brianteeman
brianteeman - comment - 2 Apr 2021

Looking good. I would keep edit files separate from the styles actions

Yeah, this together with the template delete should be on the header of the card (I guess)

Isnt it style delete?

avatar dgrammatiko
dgrammatiko - comment - 2 Apr 2021

Isnt it style delete?

Yes, there is a Delete Style but we should be able to also delete a template from this view (assuming that there's no active menu, etc). If we can pull this then from this view users could: install, delete, duplicate or create child templates and also manage all the styles. So no navigation links are required (at least this is my aim here)

avatar brianteeman
brianteeman - comment - 2 Apr 2021

you dont delete a template. you uninstall a template

avatar dgrammatiko
dgrammatiko - comment - 2 Apr 2021

you dont delete a template. you uninstall a template

you're right install/uninstall are the right terms...

avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2021
Category Administration com_menus com_templates NPM Change JavaScript com_admin com_content com_finder com_installer com_languages com_login com_media com_modules Administration com_menus com_templates Language & Strings Modules Repository NPM Change JavaScript
avatar dgrammatiko dgrammatiko - change - 20 Apr 2021
Labels Added: ?
avatar brianteeman
brianteeman - comment - 7 May 2021

@dgrammatiko what needs to be done to get this merged. IF its because its waiting on the child templates is that realisticaly achievable for 4.0. If not then can this be used without child templates

avatar dgrammatiko
dgrammatiko - comment - 8 May 2021

@dgrammatiko what needs to be done to get this merged.

  • I haven't tested the multilingual stuff
  • I need to finish the new Override creator
  • I need to patch the file manager in order to cope with both modes

It's not a huge amount of work but I always get distracted by ppl mention me in other issues so I switch branched to fix an easy bug but then refocusing here is hard. That said I should be able to move it out of WIP in the coming days

Screenshot 2021-05-08 at 11 48 15

avatar brianteeman
brianteeman - comment - 8 May 2021

great - let me know if I can help at all to get this over the final hurdles

avatar rinka88
rinka88 - comment - 16 May 2021

@dgrammatiko when can I test it? And will this be included in the upcoming release candidate?

avatar astridx
astridx - comment - 17 Jul 2021

I would also be interested to know if this function will be included in a J4 release candidate.

avatar chmst
chmst - comment - 17 Jul 2021

@astridx unfortunately too late for 4.0.

avatar astridx
astridx - comment - 17 Jul 2021

@chmst Thanks for the answer.

avatar rinka88
rinka88 - comment - 29 Jul 2021

I think we need to revive this pr. And designate which branch will be included, 4.0.x or 4.x?
@dgrammatiko @chmst

avatar dgrammatiko
dgrammatiko - comment - 29 Jul 2021

I think we need to revive this pr.

The PR was never dead but there were higher priorities for J4.0 but if you want to take over please be my guest

avatar rinka88
rinka88 - comment - 29 Jul 2021

@dgrammatiko I mean from wip. How to do this, become a guest?

avatar dgrammatiko dgrammatiko - change - 20 Aug 2021
Labels Added: Language Change ?
Removed: ? ?
414789f 4 Sep 2021 avatar dgrammatiko cs
c159cc0 4 Sep 2021 avatar dgrammatiko meh
415fb8f 4 Sep 2021 avatar dgrammatiko oops
4d7a420 4 Sep 2021 avatar dgrammatiko CS
9c85899 4 Sep 2021 avatar dgrammatiko wow
f96a563 4 Sep 2021 avatar dgrammatiko more
06a4e97 4 Sep 2021 avatar dgrammatiko more
4c2827c 4 Sep 2021 avatar dgrammatiko more
e4f608f 4 Sep 2021 avatar dgrammatiko more
71bd46d 4 Sep 2021 avatar dgrammatiko oops
4fb68f3 4 Sep 2021 avatar dgrammatiko CS
ebf8b49 4 Sep 2021 avatar dgrammatiko CS
d3ab3ab 4 Sep 2021 avatar dgrammatiko x
avatar dgrammatiko dgrammatiko - change - 4 Sep 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2021
Category Administration com_menus com_templates NPM Change JavaScript Language & Strings Modules Repository Administration com_menus com_templates Language & Strings Modules Repository NPM Change
avatar dgrammatiko
dgrammatiko - comment - 4 Sep 2021

Sneak preview for the overrides creator:

Sep-04-2021.18-06-28.mp4
avatar RickR2H
RickR2H - comment - 5 Sep 2021

@dgrammatiko let me know if I can help test the feature! ?

avatar dgrammatiko
dgrammatiko - comment - 5 Sep 2021

@RickR2H it's not fully functional atm (it creates just the html dir structure in the template) but if you have some time and test the front end and give some feedback that would be valuable

avatar dgrammatiko
dgrammatiko - comment - 5 Sep 2021

Sneak preview of template duplication/Child template creation

Screenshot 2021-09-05 at 18 06 27

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2021
Category Administration com_menus com_templates NPM Change Language & Strings Modules Repository Administration com_menus com_templates Language & Strings Modules
avatar dgrammatiko dgrammatiko - change - 6 Sep 2021
Labels Removed: NPM Resource Changed
avatar chmst
chmst - comment - 9 Sep 2021

It was my dream since I am using Joomla to have the two template views in one, thanks for working on that.

But I have a few remarks and think ithat the appearance should be consistent with atum.

  • In the menu an Icon-arrow-down stands for installation when on all other places atum uses icon-upload
  • A select list where I expect options for selection is not a select list but kind information bubble
  • What means the word Legacy here?
  • A cog the actions dropdown (@brianteeman uses another coq for that withour dropdown arrow)
  • Icons for actions are not unique (delete = uninstall, fork = new)
  • h3 tag for "styles" is a rupture in the structure (a11y).
  • would be nice to have the same behaviour of the default icon as in other lists.
avatar dgrammatiko
dgrammatiko - comment - 9 Sep 2021

But I have a few remarks and think ithat the appearance should be consistent with atum.

Generally speaking, this is still WIP so things will eventually be more consistent

A select list where I expect options for selection is not a select list but kind information bubble

There are 2 commands there: send email to support and get the template description

What means the word Legacy here?

Legacy is referring to the templates that CANNOT have child templates, Modern will be the ones that do support them

h3 tag for "styles" is a rupture in the structure (a11y).

The card footer is not really representative of what will be there finally, it needs work

would be nice to have the same behaviour of the default icon as in other lists.

There's a star icon that is supposed to do that, the logic is missing atm

About all the icons, I just picked random ones but it's an easy task to change them

avatar dgrammatiko
dgrammatiko - comment - 13 Nov 2021

This one could be revisited in v5

avatar dgrammatiko dgrammatiko - change - 13 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-13 11:56:22
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 13 Nov 2021
avatar brianteeman
brianteeman - comment - 13 Nov 2021

@dgrammatiko please re-open this. Dont allow yourself to be bullied by ignorant fools (unless of course they were correct and you were paid to mess joomla up as claimed on tiwtter)

avatar dgrammatiko
dgrammatiko - comment - 13 Nov 2021

@brianteeman this is replaced by

for 4.1 according to the maintainers' guidance. This can still be valid for another release.
I'm currently trying to finish the missing part (the file editing portion) but I saw your comment #35911 (comment) and I'm trying to figure a way to satisfy the a11y needs. It would be helpful if I wasn't triggered earlier by someone that doesn't understand that the web evolves and new features cannot always be introduced without B/C breaks. Also unfortunately I haven't been paid, but even if someone offered money for some unethical coding I wouldn't accept it. Maybe that's the reason I'm not rich...

avatar rinka88
rinka88 - comment - 19 Aug 2023

I know this thread is closed. But I would like to know whether such a view will be implemented in the next versions?
(Since version 5 is coming)

avatar dgrammatiko
dgrammatiko - comment - 19 Aug 2023

@rinka88 I can only say that I'm not working on this anymore (and nobody asked me to do so), for anything related to v5 you have to ask @HLeithner

avatar rinka88
rinka88 - comment - 19 Aug 2023

it would be a pity if such good things were lost. And you can not offer them in the form of pr?

avatar dgrammatiko
dgrammatiko - comment - 19 Aug 2023

And you can not offer them in the form of pr?

I'm afraid this is not the right way, let me explain: finishing this PR means I have to personally spend many man-hours coding/styling/testing/etc with a huge uncertainty if the PR will ever get merged (if not it was just wasted time). I cannot afford to dedicate the needed time right now, but even I was able to do so, I wouldn't do that before the maintainers gave me a clear signal that this work won't be ignored/turned down...

Anyways, September is a very busy month for me and I think after September there's no reasonable time to make this happen. Maybe in 5.1 or later (if people are not too attached to b/c breaks within a single component) and there is a competent release leader...

Add a Comment

Login with GitHub to post a comment