User tests: Successful: Unsuccessful:
Pull Request for Issue # .
One view to rule them all.
This PR largely is the adoption of the work that was done by @kawshar and his team in their backend template. So all the kudos should go to them, I'm just bringing their code to the current branch (with their permissions)
This is part of a wider rewrite of com_templates, probably has some a11y issues but should be functionally on par with the previous state (actually should be better as everything is one click away)
Install template with one click
@brianteeman can you review the a11y and the strings here?
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_menus com_templates Language & Strings Repository NPM Change |
Labels |
Added:
?
NPM Resource Changed
?
|
Category | Administration com_menus com_templates Language & Strings Repository NPM Change | ⇒ | Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript |
Go to Home Dashboard.
Click Cog icon under Site and select Edit.
Remove Template Code Icon
option.
Category | Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript | ⇒ | Administration com_menus com_templates Language & Strings Modules Repository NPM Change JavaScript |
I dont know, should I create new issue, but I write my suggestion in this PR.
When I upgrade Joomla 4.0.0 beta8-dev to new daily version (check updates and reinstall Joomla core files), sometimes there is a notification "%number% overriden files changed" and in this frame text changed to "%number% overrides to check".
I go to administrator/index.php?option=com_templates&view=templates, in override files column show yellow "changes found". Usually it happens with helixultimate template (new 2.0.0 beta version). With cassiopeia that notification not showing.
My suggestion: show, which of files has changed or overriden. Maybe it be useful for @dgrammatiko attempt to rewrite com_template.
Or it's unnecessary function?
The main change I would make is the way that multiple styles of the same template are handled.
In khansu they were all listed together but in this version they duplicate all the other template stuff.
Plus the preview is for the style not the template. So I would be looking to make the layout more like
My suggestion: show, which of files has changed or overriden.
And if there are 25 changed files?
Plus the preview is for the style not the template. So I would be looking to make the layout more like
That was easy
In khansu they were all listed together but in this version they duplicate all the other template stuff.
This needs some query tweaking
@brianteeman I don't know about that, it's just my suggestion :) I think, when number of changed files are more than 15-20, it's hard to read list all of them.
Maybe it's unnesessary function.
@dgrammatiko I think you also need to rethink the actions menu - it might not even be needed - so that its clear if the action is for the style or the template
Looks good. The Title bar might be Templates: Site or Templates Administrator as required. I think the default template should no be 'deletable'. And I guess the double icons for Info and Preview will get fixed. The first screen grab shows a different side menu order - I assume that is a user choice and not an intended default (no need to answer that unless it is).
Why don't you use the exact UX that we proposed?
Another thought: I wonder if Edit Files
and Edit Style
might be simplified to Files
and Options
? For me the word Style leads me to expect to do something with css but that is done by editing user.css.
I have tested this item
Nice changes.
I really hope it will be accepted.
The quickicon doesnt display. I have made a pr to your branch to fix that
dgrammatiko#1
Can I still make a copy of a template in this PR? I can't find the button.
Only for Legacy templates. The new mode - (able for child templates) won't have the duplicate functionality because they don't need it, you can have child templates instead.
Click Overrides are up to date
I'll have to check why it's broken, bet I have to say that the overrides checks are very badly implemented, maybe I will redo them or if it is too messy will have to ask for removal and reintroduce them properly in 4.1 or later
Category | Administration com_menus com_templates Language & Strings Repository NPM Change JavaScript Modules | ⇒ | Administration com_admin com_content com_finder com_installer com_languages com_login JavaScript com_media NPM Change com_menus com_modules com_templates |
Ok an update here, there's still a bit more work for this view but I want to share this as some of the comments are already addressed or I'm currently working on them:
The template card now looks like this (addressing @brianteeman 's comment of not having multiple cards per template, just to mention that the khansu had one card per style) :
Not all the actions are yet wired to the backend and also the child templates are not yet properly in the loop. In sort still WIP...
Labels |
Removed:
?
|
Looking good. I would keep edit files separate from the styles actions. Otherwise keep up the great work
Looking good. I would keep edit files separate from the styles actions
Yeah, this together with the template delete
should be on the header of the card (I guess)
Looking good. I would keep edit files separate from the styles actions
Yeah, this together with the
template delete
should be on the header of the card (I guess)
Isnt it style delete?
Isnt it style delete?
Yes, there is a Delete Style
but we should be able to also delete a template from this view (assuming that there's no active menu, etc). If we can pull this then from this view users could: install, delete, duplicate or create child templates and also manage all the styles. So no navigation links are required (at least this is my aim here)
you dont delete a template. you uninstall a template
you dont delete a template. you uninstall a template
you're right install/uninstall are the right terms...
Category | Administration com_menus com_templates NPM Change JavaScript com_admin com_content com_finder com_installer com_languages com_login com_media com_modules | ⇒ | Administration com_menus com_templates Language & Strings Modules Repository NPM Change JavaScript |
Labels |
Added:
?
|
@dgrammatiko what needs to be done to get this merged. IF its because its waiting on the child templates is that realisticaly achievable for 4.0. If not then can this be used without child templates
@dgrammatiko what needs to be done to get this merged.
It's not a huge amount of work but I always get distracted by ppl mention me in other issues so I switch branched to fix an easy bug but then refocusing here is hard. That said I should be able to move it out of WIP in the coming days
great - let me know if I can help at all to get this over the final hurdles
@dgrammatiko when can I test it? And will this be included in the upcoming release candidate?
I would also be interested to know if this function will be included in a J4 release candidate.
I think we need to revive this pr. And designate which branch will be included, 4.0.x or 4.x?
@dgrammatiko @chmst
I think we need to revive this pr.
The PR was never dead but there were higher priorities for J4.0 but if you want to take over please be my guest
@dgrammatiko I mean from wip. How to do this, become a guest?
Labels |
Added:
Language Change
?
Removed: ? ? |
Labels |
Added:
?
Removed: ? |
Category | Administration com_menus com_templates NPM Change JavaScript Language & Strings Modules Repository | ⇒ | Administration com_menus com_templates Language & Strings Modules Repository NPM Change |
Sneak preview for the overrides creator:
@dgrammatiko let me know if I can help test the feature!
Category | Administration com_menus com_templates NPM Change Language & Strings Modules Repository | ⇒ | Administration com_menus com_templates Language & Strings Modules |
Labels |
Removed:
NPM Resource Changed
|
It was my dream since I am using Joomla to have the two template views in one, thanks for working on that.
But I have a few remarks and think ithat the appearance should be consistent with atum.
But I have a few remarks and think ithat the appearance should be consistent with atum.
Generally speaking, this is still WIP so things will eventually be more consistent
A select list where I expect options for selection is not a select list but kind information bubble
There are 2 commands there: send email to support and get the template description
What means the word Legacy here?
Legacy is referring to the templates that CANNOT have child templates, Modern will be the ones that do support them
h3 tag for "styles" is a rupture in the structure (a11y).
The card footer is not really representative of what will be there finally, it needs work
would be nice to have the same behaviour of the default icon as in other lists.
There's a star icon that is supposed to do that, the logic is missing atm
About all the icons, I just picked random ones but it's an easy task to change them
This one could be revisited in v5
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-13 11:56:22 |
Closed_By | ⇒ | dgrammatiko |
@dgrammatiko please re-open this. Dont allow yourself to be bullied by ignorant fools (unless of course they were correct and you were paid to mess joomla up as claimed on tiwtter)
@brianteeman this is replaced by
for 4.1 according to the maintainers' guidance. This can still be valid for another release.
I'm currently trying to finish the missing part (the file editing portion) but I saw your comment #35911 (comment) and I'm trying to figure a way to satisfy the a11y needs. It would be helpful if I wasn't triggered earlier by someone that doesn't understand that the web evolves and new features cannot always be introduced without B/C breaks. Also unfortunately I haven't been paid, but even if someone offered money for some unethical coding I wouldn't accept it. Maybe that's the reason I'm not rich...
I know this thread is closed. But I would like to know whether such a view will be implemented in the next versions?
(Since version 5 is coming)
@rinka88 I can only say that I'm not working on this anymore (and nobody asked me to do so), for anything related to v5 you have to ask @HLeithner
it would be a pity if such good things were lost. And you can not offer them in the form of pr?
And you can not offer them in the form of pr?
I'm afraid this is not the right way, let me explain: finishing this PR means I have to personally spend many man-hours coding/styling/testing/etc with a huge uncertainty if the PR will ever get merged (if not it was just wasted time). I cannot afford to dedicate the needed time right now, but even I was able to do so, I wouldn't do that before the maintainers gave me a clear signal that this work won't be ignored/turned down...
Anyways, September is a very busy month for me and I think after September there's no reasonable time to make this happen. Maybe in 5.1 or later (if people are not too attached to b/c breaks within a single component) and there is a competent release leader...
looks good. will test properly later