? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Mar 2021

The three buttons for add/delete/move that are displayed as a group for repeatable fields are too small. This is an accessibility and usability problem as it makes it difficult to select the correct button.

The apple ios guidelines for touch targets suggest 44px and the equivalent for android is 48.

By simply removing the btn-sm class from these buttons we satisfy those guidelines and its much much easier to select the correct button

This can be tested by creating a field of type subform and/or in the User options go to the email domain settings

Before

image

After

image

avatar brianteeman brianteeman - open - 26 Mar 2021
avatar brianteeman brianteeman - change - 26 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2021
Category Layout
avatar richard67
richard67 - comment - 26 Mar 2021

@brianteeman Does it solve issue #32751 ? To me it seems so. If yes, could you add it to the description of the PR and let me know so I can close the issue? Thanks in advance.

avatar richard67
richard67 - comment - 26 Mar 2021

Hmm, or am I mixing up repeatable and subform stuff now?

avatar drmenzelit drmenzelit - test_item - 26 Mar 2021 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 26 Mar 2021

I have tested this item successfully on c7e528d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32873.

avatar dgrammatiko dgrammatiko - test_item - 26 Mar 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 26 Mar 2021

I have tested this item successfully on c7e528d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32873.

avatar richard67 richard67 - change - 26 Mar 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 26 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32873.

avatar brianteeman
brianteeman - comment - 26 Mar 2021

@richard67 same problem but I assume that issue is for J3?

avatar chmst chmst - close - 26 Mar 2021
avatar chmst chmst - merge - 26 Mar 2021
avatar chmst chmst - change - 26 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-26 12:13:46
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 26 Mar 2021

Thanks!

avatar brianteeman
brianteeman - comment - 26 Mar 2021

thanks

Add a Comment

Login with GitHub to post a comment