[#32861] - Adding an attribute aria-valuemin and aria-valuemax in Progress bar
- Closed
- 25 Mar 2021
- Medium
- Build: 4.0-dev
- # 32861
- Diff
- Shubham-com:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
aria-valuemin attribute is used to define the minimum value allowed for a range widget such as a slider, spinbutton or progressbar.
aria-valuemax attribute is used to define the maximum value allowed for a range widget such as a slider, spinbutton or progressbar.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
Yes,I think that it needed to define the maximum and minimum value of a Progress bar.
Can I suggest that you check again
aria-valuemin is a required attribute of role slider, scrollbar and spinbutton.
this here has role="progressbar"
I am not an expert, but I am against adding what is not required
OK - seems that no one is looking at how the code works. - I was trying to be nice and let you see for yourself.
The progress bar should have a min/max etc
The progress bar has a min/max it is set in the javascript
The progress bar has a min/max it is set in the javascript
so then it's fine
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 12:30:34 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Ok..thanks now I got it..
I am new this codebase..I have not seen that it is already defined in javascript.
@Shubham-com You would have seen if you had done the most important thing. Tested. Code does not live in an IDE.
Did you actually check that this was needed before making the pull request