Feeling Lucky
?
[#32849] - [4] s/DateTime/DateTimeInterface for RFC2822
- Fixed in Code Base
- 25 Mar 2021
- Medium
- Build: 4.0-dev
- # 32849
- Diff
- PhilETaylor:RFC822
User tests: Successful: Unsuccessful:
Summary of Changes
According to phpStorm, "RFC2822 was removed in PHP 7.2"
Reference in phpStorm https://github.com/JetBrains/phpstorm-stubs/pull/297/files
Reference in php-src php/php-src#2483
I believe what they are trying to say is that the constants were moved from the DateTime to the DateTimeInterface in PHP 7.2
Testing Instructions
The new unit tests cover this - cough cough - test those at #32848
Manually run:
$date = new Date("8th March 1978 6:06pm", new \DateTimeZone('UTC'));
echo $date->toRFC822(); // Should give 'Wed, 08 Mar 1978 18:06:00 +0000'
Actual result BEFORE applying this Pull Request
'Wed, 08 Mar 1978 18:06:00 +0000'
Expected result AFTER applying this Pull Request
'Wed, 08 Mar 1978 18:06:00 +0000' but phpStorm is happy
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-25 14:46:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Seems fine. Definitely will work either way. But can't hurt to use the interface