? ? ? Failure

User tests: Successful: Unsuccessful:

avatar Ganesh163
Ganesh163
24 Mar 2021

Pull Request for Issue #32793.

Summary of Changes

Added a helper text "Only status codes from 300-399 correspond to a redirect.", So that the user inputs the correct status code.

Testing Instructions

  • Login as administrator
  • Go to System -> Redirects -> New/ Edit.
  • The help text can be seen below.

Actual result BEFORE applying this Pull Request

111921232-64bb0f00-8a8b-11eb-8ba5-72dac816b0af

Expected result AFTER applying this Pull Request

Updated status code

Documentation Changes Required

avatar Ganesh163 Ganesh163 - open - 24 Mar 2021
avatar Ganesh163 Ganesh163 - change - 24 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2021
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 24 Mar 2021

Are you saying that if a status code other than 300-399 is selected then there will not be a redirect?

avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2021

Are you saying that if a status code other than 300-399 is selected then there will not be a redirect?

Thats EXACTLY the point. The Redirects system in Joomla DOESNT REDIRECT if you have advanced mode on and select a code outside 300-399. Then it just returns a RESPONSE with the selected heading. Which is not the purpose of a "redirect" system :-(

if ($redirect->header < 400 && $redirect->header >= 300)

Full detail was explained in #32793

avatar Quy Quy - change - 24 Mar 2021
The description was changed
avatar Quy Quy - edited - 24 Mar 2021
avatar Ganesh163 Ganesh163 - change - 24 Mar 2021
Labels Added: ? ?
avatar saumyasarkar11
saumyasarkar11 - comment - 25 Mar 2021

Please add [4.0] to the PR title

avatar Ganesh163 Ganesh163 - change - 25 Mar 2021
Title
Changed the helper text in Redirect plugins Advanced settings
[4.0]Changed the helper text in Redirect plugins Advanced settings
avatar Ganesh163 Ganesh163 - edited - 25 Mar 2021
avatar Ganesh163
Ganesh163 - comment - 25 Mar 2021

Added! Thanks

avatar Quy
Quy - comment - 27 Mar 2021

Let's add the following to new_url in link.xml:

showon="header:300,301,302,303,304,305,306,307,308"

avatar sandramay0905
sandramay0905 - comment - 9 Apr 2021

Shouldn't Issue #32793 be closed or is this pr not good?

avatar michwebdev michwebdev - test_item - 23 Apr 2021 - Tested successfully
avatar michwebdev
michwebdev - comment - 23 Apr 2021

I have tested this item successfully on d77e0ce

This worked. I needed to "Activate Advanced Mode" in the Redirects options in order to see the Redirect Status Code option.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32840.

avatar Quy Quy - test_item - 23 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 23 Apr 2021

I have tested this item successfully on d77e0ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32840.

avatar Quy Quy - change - 23 Apr 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32840.

avatar chmst chmst - close - 23 Apr 2021
avatar chmst chmst - merge - 23 Apr 2021
avatar chmst chmst - change - 23 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-23 15:12:36
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 23 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment