Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32822] - [4] Ensure template logo has relative links regardless of SEF Settings

? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
23 Mar 2021

Pull Request for Issue Closes #31989
Replacement PR for #32714

Summary of Changes

Prepend templatePath with Uri:root to Ensure templatePath is always absolute and not a broken relative url

Testing Instructions

See #31989

Visit frontend , click a menu link in the left menu to get to an article
Note that the CASSIOPEIA logo (white text on blue background) is present

In Joomla Admin disable the "System - SEF" plugin

Refresh your article page on the frontend

Note the logo is now a broken image

Actual result BEFORE applying this Pull Request

paths are relative, and therefore image doesn't display when non-SEF mode and not at / (ie. in a sub folder or not on the home page where url contains /index.php/path/to like http://127.0.0.1:4444/index.php/component/users/reset?Itemid=101)

Expected result AFTER applying this Pull Request

regardless of SEF plugin status, the image and assets loaded from $templatePath load correctly.

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 23 Mar 2021
avatar PhilETaylor PhilETaylor - change - 23 Mar 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2021
Category ⇒ Front End Templates (site)
avatar PhilETaylor PhilETaylor - change - 23 Mar 2021
Title
…
Ensure template logo has relative links regardless of SEF Settings
[4] Ensure template logo has relative links regardless of SEF Settings
avatar PhilETaylor PhilETaylor - edited - 23 Mar 2021
avatar PhilETaylor PhilETaylor - change - 24 Mar 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2021

Switched to Joomla API with preceding / to make it actually work.

avatar dgrammatiko dgrammatiko - test_item - 24 Mar 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 24 Mar 2021

I have tested this item ✅ successfully on 2898ee9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32822.

avatar toivo toivo - test_item - 24 Mar 2021 - Tested successfully
avatar toivo
toivo - comment - 24 Mar 2021

I have tested this item ✅ successfully on 2898ee9

Tested successfully in Beta8-dev of 24 March in Wampserver 3.2.4 using PHP 8.0.2.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32822.

avatar Quy Quy - change - 24 Mar 2021
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 24 Mar 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32822.

avatar drmenzelit drmenzelit - close - 25 Mar 2021
avatar drmenzelit drmenzelit - merge - 25 Mar 2021
avatar drmenzelit drmenzelit - change - 25 Mar 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-03-25 09:34:09
Closed_By ⇒ drmenzelit
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 25 Mar 2021

Thanks!

Add a Comment

Login with GitHub to post a comment