[#32789] - [4.0] Missing bottom border in modal
- Closed
- 22 Mar 2021
- Medium
- Build: 4.0-dev
- # 32789
- Diff
- NikitaEmberi:temp#32190-3
User tests: Successful: Unsuccessful:
Pull Request for Issue #32190
Summary of Changes
Changes as suggested in:#32190 (comment)
and #32762 (comment)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds com_users Templates (admin) NPM Change |
| Title |
|
||||||
Please can someone help me how to resolve conflict. I am not really understanding what is wrong.
Which conflict? I don't see any conflict here. I only see code style errors reported by drone. If you follow the details you end at the log file here: https://ci.joomla.org/joomla/joomla-cms/40993/1/6 .
It mainly says you have to use tabs to indent code.
And which PR is right now? This one or #32786 ? They use different branches but are identical regarding changes. Please close one of these two. There is a button for closing it at the bottom of the PR.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds com_users Templates (admin) NPM Change | ⇒ | Administration com_associations com_categories com_contact com_content com_fields com_modules com_newsfeeds com_users |
I'll resolve code style issue and open a new PR. Thank you for letting me know my mistake and I apologize for carelessly opening a PR.
You don't need to open a new PR, you can correct your code and make a new commit.
rdeutz
- | Title |
|
||||||
| Labels |
Removed:
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-22 20:11:09 |
| Closed_By | ⇒ | NikitaEmberi |
Please can someone help me how to resolve conflict. I am not really understanding what is wrong.