upstream submitted too joomla-framework/application#94

I have tested this item ✅ successfully on 9bf6767

Code review.

I have tested this item ? unsuccessfully on 9bf6767

Code review.

@SharkyKZ ????

It is my understanding that files in vendor directory should be made upstream and then migrated downstream.

for those installable by composer maybe.... but are not these forked versions that are in the 4.0-dev?

upstream submitted too joomla-framework/application#94

and looking at the last modified commits of the files in https://github.com/joomla/joomla-cms/tree/4.0-dev/libraries/src would suggest that Im right :)

Last time this file was fetched from the framework was in 2019 or earlier. This commit in the framework hasn't arrived in the CMS yet: joomla-framework/application@134f298 .

But that's the only difference between the CMS and the framework version.

So here it could indeed make sense to do the change in the framework and later pull it into the CMS.

We have other framework stuff were we have more differences between framework and CMS, like e.g. database, and where we changed things in the CMS and later pulled it up into the framework, and I thought that's the case here, too, that's why I haven't insisted in doing it upstream in the framework.

All that said only for J3 (staging, 3.10-dev). For J4 it's definitely different.

Im not going to argue for a typo.

See also joomla-framework/application#94 and joomla-framework/application#95 ... we gotta pull the changes from the framework as soon as the PR's there got merged.

Thanks @PhilETaylor for reporting and making the PR's there.