Feeling Lucky
?
[#32774] - [4] Missing?
- Closed
- 21 Mar 2021
- Medium
- Build: 4.0-dev
- # 32774
- Diff
- astridx:npm
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
brianteeman
- comment
- 21 Mar 2021
Look again;)
astridx
- comment
- 21 Mar 2021
hm, this appeared for me after I ran npm ci. This is probably an error on my part.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-21 16:12:23 |
| Closed_By | ⇒ | astridx | |
| Labels |
Added:
?
|
||
dgrammatiko
- comment
- 21 Mar 2021
@astridx this is a legit PR, can you reopen it?
@richard67 can you merge this on review? (explanation what happed here: we updated the package.json without running npm install so not all changes were applied)
Ignore me, the current versions are aligned
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-21 16:12:23 | ⇒ | |
| Closed_By | astridx | ⇒ |
| Status | New | ⇒ | Pending |
brianteeman
- comment
- 21 Mar 2021
@dgrammatiko you are wrong.
As I explained - if you run npm install then it will update these packaged and the xml files. You then have to commit these two xml AND the package.json and package-lock.json
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-21 19:34:37 |
| Closed_By | ⇒ | astridx |
This is not correct.
Those files are updated by the build scripts.
So you need to have updated the packages defined in npm in order to have those versions.
Therefore you need to commit the updated package.json and package-lock.json as well