Feeling Lucky
?
?
[#32770] - [4.0] subform buttons
- Fixed in Code Base
- 21 Mar 2021
- Medium
- Build: 4.0-dev
- # 32770
- Diff
- brianteeman:bird_or_plane
User tests: Successful: Unsuccessful:
Does it go somewhere? It's a link
Does it do something? It's a button
This PR corrects the usage of an a when it should be a button in the non-table repeatable layouts. You can see this in action in the CSP options after selecting custom mode and scrolling down the page.
There is no visible or functional change.
Note the javascript can probably be updated to not listen for a spacebar key as that is native for a button - this is beyond the scope of this PR.
PS I already did this once before in #26614
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Quy
- comment
- 21 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32770.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 21 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32770.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-21 23:44:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 21 Mar 2021
Thanks!
brianteeman
- comment
- 22 Mar 2021
thanks
I have tested this item✅ successfully on 31fade9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32770.