Feeling Lucky
NPM Resource Changed
?
[#32742] - Two icons on some buttons
- Closed
- 23 Mar 2021
- Medium
- Build: 4.0-dev
- # 32742
- Diff
- NikitaEmberi:temp#30018
User tests: Successful: Unsuccessful:
Pull Request for Issue #30018
Summary of Changes
modified _icon.scss to move the external link icon after the text of the button.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
(If I try to add padding of more than 2px, it squashes the alignment of buttons like this:
so that is why I added a padding of only 2px. )
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
NikitaEmberi
- comment
- 19 Mar 2021
@infograf768 sir I opened the pull request 'install-from-web-server' as explained in #30018 (comment) please could you review the pr and let me know if I was right.
Quy
- comment
- 19 Mar 2021
NikitaEmberi
- comment
- 21 Mar 2021
Quy
- comment
- 23 Mar 2021
Closing as stated above. Fix should be done in the other repo. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-23 15:47:06 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
NPM Resource Changed
?
|
||
This is not the solution. As explained in #30018 (comment)
We most likely need to solve the issue upstream by taking off the icons there for these 3 cases and just keep the default in core.