Feeling Lucky
?
[#32716] - Update captive.php
- Closed
- 18 Mar 2021
- Medium
- Build: 4.0-dev
- # 32716
- Diff
- mariantanase:4.0-dev
User tests: Successful: Unsuccessful:
Add some space betweeb two buttons (CANCEL and INSTALL) when doing update.
See Issue [#32700]
Thanks @infograf768
Pull Request for Issue #32700 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
dgrammatiko
- comment
- 17 Mar 2021
This is totally wrong, you cannot nest a link inside a button element, check https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button permitted parents.
infograf768
- comment
- 17 Mar 2021
@dgrammatiko
you are correct.
infograf768
- comment
- 18 Mar 2021
@mariantanase
I'm afraid this PR is wrong (my proposal in #32700 was no good) and as it is also based on an obsolete 4.0-dev, I suggest you close it.
When done we will reopen #32700
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-18 07:38:01 |
| Closed_By | ⇒ | mariantanase | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 18 Mar 2021
@dgrammatiko
Would using an onclick be OK?
<div class="control-group">
<div class="controls">
<button type="button" class="btn btn-danger" onclick="window.location.href='index.php?option=com_joomlaupdate';">
<span class="icon-times icon-white" aria-hidden="true"></span> <?php echo Text::_('JCANCEL'); ?>
</button>
<button type="submit" class="btn btn-primary">
<span class="icon-play icon-white" aria-hidden="true"></span> <?php echo Text::_('COM_INSTALLER_INSTALL_BUTTON'); ?>
</button>
</div>
</div>
Looks like you created the pr based on an older version of 4.0-dev . in fact a beta4.
This needs correcting.