? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
17 Mar 2021

Closes #32623

Summary of Changes

  • Simplified links display code in article/default.php.
  • Added additional option "Don't display"/JHIDE to setting urls_position if somebody doesn't want to display links at all (or wants to use the feature elsewhere).
  • Removed $urls = json_decode($this->item->urls); in article/.../default.php.
  • Add indents in components/com_content/tmpl/article/default.xml

Testing Instructions

  • Optional: If you want to test the default behavior of a clean Joomla 4 before you apply the patch.

    • Install Joomla 4 nightly.
    • "Install Blog Sample Data" in Control Panel.
    • See an article in front-end. Debug $params in components\com_content\tmpl\article\default.php. There is no parameter for urls_position in it.
      • That's the reason why I use (int) in PHP code for B\C reasons.
  • Edit article "Welcome to your blog". Add a link/url in tabulator Images and Links. Save article.

  • Link is displayed Above (inherited global setting) in front-end.

  • Apply patch

    • See article in front-end. Link is still displayed above (global setting).
    • Play around with the setting Positioning of the Links in
    • Article edit.
    • administrator/index.php?option=com_config&view=component&component=com_content

Documentation Changes Required

I don't know. New setting "Hide".

avatar ReLater ReLater - change - 17 Mar 2021
Status New Pending
avatar ReLater ReLater - open - 17 Mar 2021
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2021
Category Administration com_content
avatar ReLater ReLater - change - 17 Mar 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2021
Category Administration com_content Administration com_content Front End
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
Title
Clearer urls_position. WORK IN PROGRESS!
[4] Clearer code for urls_position (com_content article default.php)
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar chmst
chmst - comment - 17 Mar 2021

Additional information to testing instructions:

"Add a link/url in tabulator Images and Links. Save article.",
is only possible if the parameter "Frontend Images and Links" in Article Options is set.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32713.
avatar chmst chmst - test_item - 17 Mar 2021 - Tested successfully
avatar chmst
chmst - comment - 17 Mar 2021

I have tested this item successfully on 48e4355


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32713.

avatar ReLater ReLater - change - 17 Mar 2021
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2021
avatar ReLater
ReLater - comment - 17 Mar 2021

is only possible if the parameter "Frontend Images and Links" in Article Options is set.

Thanks! Instruction extended.

avatar jwaisner jwaisner - test_item - 18 Mar 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 18 Mar 2021

I have tested this item successfully on 48e4355


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32713.

avatar jwaisner jwaisner - change - 18 Mar 2021
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 18 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32713.

avatar rdeutz rdeutz - close - 18 Mar 2021
avatar rdeutz rdeutz - merge - 18 Mar 2021
avatar rdeutz rdeutz - change - 18 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-18 18:48:14
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment