? Success

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
10 Mar 2014

This commit creates a layout for the readmore button and uses this layout in featured/default_item.php and category/blog_item.php.

JoomlaCode item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33446

avatar Harmageddon Harmageddon - open - 10 Mar 2014
avatar wilsonge
wilsonge - comment - 10 Mar 2014

Could i be a pain in the ass and ask that you use tabs in the layout rather than spaces as per Joomla standards :) Thanks!

avatar Harmageddon
Harmageddon - comment - 11 Mar 2014

I changed it, totally forgot about that. Thank you!

avatar wilsonge
wilsonge - comment - 11 Mar 2014

Ty. Works fine! Nice one!

avatar losedk
losedk - comment - 7 Apr 2014

Tested. Works fine!

avatar drmmr763
drmmr763 - comment - 31 May 2014

So I tried to test this and I'm getting a merge conflict. I don't see it noted here but can you just doublecheck? It could be an issue on my end. [#jab14]

avatar Harmageddon Harmageddon - change - 1 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-01 16:51:59
avatar Harmageddon Harmageddon - close - 1 Jun 2014
avatar Harmageddon Harmageddon - close - 1 Jun 2014
avatar Harmageddon Harmageddon - head_ref_deleted - 1 Jun 2014
avatar Harmageddon
Harmageddon - comment - 1 Jun 2014

@drmmr763
Thank you for testing! There were some changes to the affected files on staging in the meantime, so I redid my changes after long fights with git and created a new PR: #3702
Feel free to test the new PR!

Add a Comment

Login with GitHub to post a comment