description="Some description"
property for any field typeid="jform_params_FIELD_NAME-lbl"
while the field description has id="jform[params][FIELD_NAME]-desc"
. These values are taken from cassiopeia default template style as an example but I'm sure this issue applies in general to all field types in any form.IMO all fields should follow a strict pattern that doesn't confuse developers
<label id="jform_params_FIELD_NAME_lbl">
- all underscore<input id="jform_params_FIELD_NAME">
- all underscore<div id="jform_params_FIELD_NAME_desc">
- all underscoreIf this change is too dramatic, at least this would make it more consistent:
<label id="jform_params_FIELD_NAME-lbl">
- same pattern<input id="jform_params_FIELD_NAME">
- all underscore<div id="jform_params_FIELD_NAME-desc">
- same pattern<label id="jform_params_FIELD_NAME-lbl">
- not all underscore, mixed, no pattern<input id="jform_params_FIELD_NAME">
- all underscore, CHECKED, correct pattern<div id="jform[params][FIELD-NAME]-desc">
- not all underscore, brackets, no pattern, total FAILJoomal 4.0 beta 7.
Not having a correct pattern for field description id could potentially break or otherwise disrupt anything to do with accessibility as well as confuse devs into fixing/patching something that's incorrect in the core FormField
code.
@dgrammatiko suggested an overhaul of all field types to be converted to web components, if that happens, it should also take into account this issue right here.
Labels |
Added:
?
|
Please dont. This will massively break sites for no benefit. This is working perfectly as it is
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-17 08:10:05 |
Closed_By | ⇒ | thednp |
As you wish.
After a quick investigation, it turns out the issue is with renderfield.php#L35.
Should I commit a PR with necessary changes?