@Pradumn27 In addition to my review comment above I have a question: Have you checked if it needs the same fix at other places, too? The issue #32250 mentions the module edit only as an example, but there might be other places. If possible, please check and report back so we know if this PR fixes the issue completely or if there is something more to be done.

@richard67 So I had installed the sample data and checked with the different editing options available and the only editing option with a different alignment of buttons was module editing panel.

@Pradumn27 Please login on the frontend. Then you get serveral other views with frontend editing for administrators.
site settings and template settings also have buttons on top.

Modules have a hr tag which looks not good - I am not sure if this is related to the changes made here or if it is out of scope and another PR

@chmst I'm a little confused here please do correct me if I'm wrong, so in the issue, it was mentioned that the action buttons(Save, Save and Close, Cancel) of settings accessed on the front-end are inconsistent which actually are. But since you mentioned template and site settings, aren't they the settings in the backend (accessed via administrator).

@Pradumn27 yes, this are backend functions, but can be opened also on frontend,: module settings, site settings, template settings .. everything we can open on the site should have the buttons at the same place.

As it was already said #32250 (comment) - there could be more edit forms in the frontend.

So as this PR doesn't solve all the inconsistencies, I've re-opened issue #32250 since it's not fixed completely.

As pointed out by @chmst I have changed the button orientation of site and template settings in the frontend as well. Along with this, I enabled the front-end menu and module editing as well but the menu editing panel is redirected to the administrator panel(aka the backend) and since all the backend functions have the buttons at the top I think changing the menu editing panel's button orientation will make the backend's button orientation inconsistent. Please give your comments.

Sorry, no, we will not touch the template atum in backend, only the frontend. Please revert theses changes.

Have a look in the component com_config - there are two forms with buttons in top.

@chmst I haven't changed any file in the atum template just the front-end editing forms are changed.

@chmst reading this discussion do i understand correct that this PR should not be test now?

I just posted this to the issue:

Here is the list that needs to be consistent, so choose either Top or bottom and change the others, and fix the icons

I have tested this item ✅ successfully on 083e450

Worked as expected.

I have tested this item ✅ successfully on 083e450

I followed the testing instructions.

The patch worked as expected

Worked as expected.

The patch worked as expected

2 tests, but somehow this PR still doesnt address all 6 test cases I have provided.... and therefore is not enough to close #32250

2 tests, but somehow this PR still doesnt address all 6 test cases I have provided.... and therefore is not enough to close #32250

@PhilETaylor As far as I can see it addresses the 3 where buttons have to be moved from top to bottom to be consistent with the other 3. But I haven't tested myself.

RTC

Will check later on weekend if we need more fixes. I agree to leave the issue open meanwhile.