?
avatar mariantanase
mariantanase
16 Mar 2021

Steps to reproduce the issue

When upgrading from Joomla 4 Beta 7 to the current nightly build, you are prompted to enter credentials before continuing.
The two buttons (Cancel and Install) are attached. No margin or padding between them.

Expected result

Actual result

screen shot 2021-03-16 at 09 26 30

System information (as much as possible)

Joomla_4.0.0-beta8-dev
PHP 7.4.13

Additional comments

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar mariantanase mariantanase - open - 16 Mar 2021
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Mar 2021
avatar dArK-sOuL0807
dArK-sOuL0807 - comment - 16 Mar 2021

Sir, let me get a chance to fix this issue.

avatar alikon
alikon - comment - 16 Mar 2021

maybe reading this one #32697 may help

avatar richard67
richard67 - comment - 16 Mar 2021

Whoever wants to fix this issue mind the round corners of the button: When having space between the buttons, it will need all 4 corners of each button to be round.

avatar JajateeNandineeSahoo
JajateeNandineeSahoo - comment - 17 Mar 2021

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

avatar shitesh2607
shitesh2607 - comment - 17 Mar 2021

I am working on this issue.

avatar infograf768
infograf768 - comment - 17 Mar 2021

Suggestion:

diff --git a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
index bc7b120..78bc0f9 100644
--- a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
+++ b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
@@ -85,12 +85,12 @@
 		<div class="control-group">
 			<div class="controls">
-				<div class="btn-group">
+				<button type="button" class="btn">
 					<a class="btn btn-danger" href="index.php?option=com_joomlaupdate">
 						<span class="icon-times icon-white" aria-hidden="true"></span> <?php echo Text::_('JCANCEL'); ?>
 					</a>
-					<button type="submit" class="btn btn-primary">
-						<span class="icon-play icon-white" aria-hidden="true"></span> <?php echo Text::_('COM_INSTALLER_INSTALL_BUTTON'); ?>
-					</button>
-				</div>
+				</button>
+				<button type="submit" class="btn btn-primary">
+					<span class="icon-play icon-white" aria-hidden="true"></span> <?php echo Text::_('COM_INSTALLER_INSTALL_BUTTON'); ?>
+				</button>
 			</div>
 		</div>

Screen Shot 2021-03-17 at 09 29 03

avatar JajateeNandineeSahoo
JajateeNandineeSahoo - comment - 17 Mar 2021

I am working on this issue.

Okay, no problem but I just want to know that can't I work on this issue? Is it that only a single person can work on a single issue?

avatar mariantanase
mariantanase - comment - 17 Mar 2021

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

I'm sorry to tell you this, but how can you fix this issue when you don't know where to find the code to fix ?

avatar chmst
chmst - comment - 17 Mar 2021

@JajateeNandineeSahoo you can work on this issue - everyone can work on every issue. As soon as you make a pullrequest which solves the problem, the issue will be closed and we test your PR.

avatar JajateeNandineeSahoo
JajateeNandineeSahoo - comment - 17 Mar 2021

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

I'm sorry to tell you this, but how can you fix this issue when you don't know where to find the code to fix ?

Actually I'm new to open source and I don't know much about it. I'm just started learning it and I thought that may be someone would have written the path to find the code.

avatar infograf768
infograf768 - comment - 17 Mar 2021

the path is easy. look above : #32700 (comment)

avatar drmenzelit drmenzelit - close - 17 Mar 2021
avatar drmenzelit
drmenzelit - comment - 17 Mar 2021

Closing as we have a PR #32716

avatar drmenzelit drmenzelit - change - 17 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-17 14:24:31
Closed_By drmenzelit
avatar infograf768
infograf768 - comment - 18 Mar 2021

My proposal above #32700 (comment) is wrong.

avatar infograf768 infograf768 - change - 18 Mar 2021
Status Closed New
Closed_Date 2021-03-17 14:24:31
Closed_By drmenzelit
avatar infograf768 infograf768 - reopen - 18 Mar 2021
avatar infograf768
infograf768 - comment - 18 Mar 2021

Maybe this will be OK

#32716 (comment)

Reopening

avatar drmenzelit drmenzelit - change - 19 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-19 10:49:22
Closed_By drmenzelit
avatar drmenzelit drmenzelit - close - 19 Mar 2021
avatar drmenzelit
drmenzelit - comment - 19 Mar 2021

I'm closing the issue since it is the expected behaviour of a btn-group to have the buttons together without space between them: https://getbootstrap.com/docs/5.0/components/button-group/

Feel free to re-open if you think the btn-group is wrong here.

Add a Comment

Login with GitHub to post a comment