Pending

User tests: Successful: Unsuccessful:

avatar juliopontes
juliopontes
23 Aug 2012

I've found a bug when you try to copy a template and are using cache handler diff from "file".

the JFile class are not loaded and got a Fatal Error.

Report trackert link in joomlacode.

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28985

Cheers,

Julio Pontes

Ps.: Need to check this on 1.5.X
Ps.: This patch its only for 2.5.X series

avatar juliopontes juliopontes - open - 23 Aug 2012
avatar realityking
realityking - comment - 23 Aug 2012

Like we did with JFolder we should probably review what other files are missing the jimport for JFile. Would you be intrested in doing that? (You just need to grep for JFile and for the corespnding jimport. Those files in the first but not the second list need to be patched)

avatar elinw
elinw - comment - 24 Aug 2012

Were was this removal documented? Have other applications beside the cms been given timely notice (i.e. minimum one full 3 month tagged release of the platform with deprecation notice in place)?

avatar mbabker
mbabker - comment - 24 Aug 2012

This was more dependency management cleanup than removing API if I understand right. Basically, classes were loading other classes that they didn't need to, or were modified to not depend on, and other classes depended on those imported classes to already be there instead of handling their dependencies on their own.

avatar realityking
realityking - comment - 24 Aug 2012

Any file/class is responsible for loading all non-autoloadable classes. Just relying on it being loaded by something else is doomed to fail when that something else changes.

Nothing in JFile has been removed, a couple of methods have been deprecated though and so it's used less often now.

avatar juliopontes
juliopontes - comment - 24 Aug 2012

This not affect 1.5.X because dont have copy functionality.

avatar elinw
elinw - comment - 24 Aug 2012

So let's get this one merged and make it a huge priority to find places where there is breakage because dependencies were removed without adequate testing/accounting for downstream for breakage. This is why Michael is right about unit tests but nothing with potential dependency in other classes should be removed without fixing all of those at the same time. We can't have a broken trunk.
Can one of you generate a list of all classes where this import was removed and then we can grep for classes where those are called.
But let's not hold up this merge for the sake of that.

avatar infograf768
infograf768 - comment - 26 Aug 2012

Fixed this one in master as well as 2.5.x
Please open a new tracker for similar issues

avatar infograf768 infograf768 - close - 26 Aug 2012

Add a Comment

Login with GitHub to post a comment