Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32695] - [4.0] Fixing No-ID setting for nomenu router rule

? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
15 Mar 2021

Pull Request for Issue #32248.

Summary of Changes

When generating a URL to a content item that has no menu item leading to it, uses the rule-based-routers AND the "Remove IDs from URLs" option for the component is active, the router can't parse the URL again. This should fix that.

Testing Instructions

  1. In the settings of the contact component, enable "Remove IDs from URLs" and save that.
  2. Create a contact with a tag
  3. Create a menu item of type "Tags -> tagged items" with the previously used tag
  4. Go to the frontend and click on your new menu item.
  5. See the contact being listed and click on it.
  6. You get an error page. Oh no!
  7. Apply the PR.
  8. Reload the page and see that it works fine.

Thanks to @PhilETaylor for reporting this issue with good instructions.

avatar Hackwar Hackwar - open - 15 Mar 2021
avatar Hackwar Hackwar - change - 15 Mar 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2021
Category ⇒ Libraries
avatar Hackwar Hackwar - change - 15 Mar 2021
The description was changed
avatar Hackwar Hackwar - edited - 15 Mar 2021
avatar joomdonation
joomdonation - comment - 15 Mar 2021

Works well for tags, contacts. However, it is not working for com_content yet:

  1. Unpublish all menu items linked to com_content
  2. Publish the Articles - Categories module
  3. That module will display list of categories. Clicks on a category generate links in this format http://localhost/joomla4/index.php/component/content/category/components?Itemid=101 and that links throws 404 error.
avatar Hackwar Hackwar - change - 15 Mar 2021
Labels Added: ?
avatar Hackwar
Hackwar - comment - 15 Mar 2021

Hopefully this fix should do it. :-)

avatar richard67
richard67 - comment - 15 Mar 2021

@Hackwar Does this replace #20979 ?

avatar Hackwar
Hackwar - comment - 15 Mar 2021

Looking at #20979 this here looks like a better solution. So, yes, close that one.

avatar joomdonation joomdonation - test_item - 16 Mar 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 16 Mar 2021

I have tested this item ✅ successfully on ec7cb82

Tested with several core components and it is working well. Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

avatar alikon alikon - test_item - 16 Mar 2021 - Tested successfully
avatar alikon
alikon - comment - 16 Mar 2021

I have tested this item ✅ successfully on ec7cb82

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

avatar alikon alikon - change - 16 Mar 2021
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 16 Mar 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

avatar rdeutz rdeutz - close - 17 Mar 2021
avatar rdeutz rdeutz - merge - 17 Mar 2021
avatar rdeutz rdeutz - change - 17 Mar 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-03-17 10:49:04
Closed_By ⇒ rdeutz
Labels Added: ?
avatar joomleb
joomleb - comment - 11 Jan 2022

Hi guys,
seeing here that the RTC label has been removed on 17 May 2021.
Sorry, but, What about this fix and 4.1 version release ? Will it be added ?
Please, What is planned for this issue ?

avatar richard67
richard67 - comment - 11 Jan 2022

@joomleb rtc has been removed because this pr has been merged, I.e. committed, so it cannot be ready to commit anymore. It has been merged in March last year and so is part of 4.0 and 4.1 since then.

avatar joomleb
joomleb - comment - 11 Jan 2022

@richard67 Many Thanks for your help in understanding

Add a Comment

Login with GitHub to post a comment