? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
10 Mar 2014

This PR improves generating the breadcrumbs and hopefully fixes some bugs. Specifically comparing a static string against a non-changing variable is simply a waste of perfectly good CPU cycles.

avatar Hackwar Hackwar - open - 10 Mar 2014
avatar Hackwar
Hackwar - comment - 18 Jul 2014

This PR is still up-to-date.

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 22 Aug 2014

Thank you for your contribution and participation in the bug tracking process. As there has been no response to the request for further information I am closing this report at this time.

We have now moved our bug tracking process to http://issues.joomla.org/ so if you have further information that would enable this issue to be reopened please update the issue at http://issues.joomla.org/tracker/joomla-cms/3269 and it can be reopened.

avatar brianteeman brianteeman - change - 22 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-22 10:45:04
avatar brianteeman brianteeman - close - 22 Aug 2014
avatar brianteeman brianteeman - close - 22 Aug 2014
avatar Hackwar
Hackwar - comment - 24 Aug 2014

Hello Brian, thx for bringing this one up again. The bug and PR is still current and could be re-opened. I have to admit that I don't know what the specific behavior of this bug was, but from checking the code again, I can say that the PR makes this behave the way it is supposed to be.

To test this, you would have to create a menu item as a parent item with a random type, then set up menu items for the different component views (contact category, content category, content article, newsfeed category, newsfeed newsfeed and weblink category) and link each to a respective item/category. In the categories, you would have to have subcategories and in those subcategories you would need items that are not linked in the menu. In the end, you should be able to navigate to something like this:
/<parent_menu_item>/<active_menu_item>/<category_42>/<item_21>
as an example URL. This structure should be represented in the breadcrumbs. This PR should only affect the displayed hierarchy of the breadcrumbs.

So, if you feel that this bug is important enough and the explanation is okay, please re-open it. :smile:

avatar brianteeman brianteeman - change - 24 Aug 2014
Status Closed New
avatar brianteeman brianteeman - reopen - 24 Aug 2014
avatar brianteeman brianteeman - reopen - 24 Aug 2014
avatar brianteeman
brianteeman - comment - 24 Aug 2014

Re-opened as requested

avatar brianteeman brianteeman - change - 24 Aug 2014
Status New Pending
avatar Hackwar
Hackwar - comment - 14 Nov 2014

This PR needs a review from a maintainer. It is hard to test this, but if you review the code, you see the issues...

avatar wilsonge
wilsonge - comment - 28 Dec 2014

Your file for the JDocumentXmlTest that got accidently removed then recommitted was given a slightly different name if you look at the diff. You need to change XML to Xml

avatar Hackwar
Hackwar - comment - 1 Feb 2015

Ok, so, I don't really want to re-do this whole PR to get the JDocumentXmlTest thing fixed and I also think that I would rather want to fix this whole thing on a different level. Since this PR also moves towards its first anniversary, I'm closing it. When the routing is done, I will revisit this and create a new PR.

avatar Hackwar Hackwar - close - 1 Feb 2015
avatar Hackwar Hackwar - change - 1 Feb 2015
Status Pending Closed
Closed_Date 2014-08-22 10:45:04 2015-02-01 09:55:34

Add a Comment

Login with GitHub to post a comment