? Pending

User tests: Successful: Unsuccessful:

avatar sksuryan
sksuryan
14 Mar 2021

Pull Request for Issue #32679 .

Summary of Changes

This PR fixes the issue where the table in Mailing templates would fail to be responsive because of long IDs since they are treated as a single word, causing an overflow. Hence, to fix this problem, text-break class for ID column has been added.

Further, this PR tweaks alignment of text in Mail templates table to visually make it better.

Testing Instructions

  • Login to Administrator.
  • Go to System > Mail Templates.
  • Use Dev tools to resize the window. The overflow could be seen at around 1024px.

Actual result BEFORE applying this Pull Request

image
image

Expected result AFTER applying this Pull Request

The table should be responsive and be able to adapt to smaller widths.

image

avatar sksuryan sksuryan - open - 14 Mar 2021
avatar sksuryan sksuryan - change - 14 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2021
Category Administration
avatar brianteeman
brianteeman - comment - 14 Mar 2021

Text in columns should always be aligned left and never centered

avatar sksuryan
sksuryan - comment - 14 Mar 2021

Okay, will revert this back.

avatar sksuryan sksuryan - change - 14 Mar 2021
Labels Added: ?
avatar sksuryan sksuryan - change - 14 Mar 2021
The description was changed
avatar sksuryan sksuryan - edited - 14 Mar 2021
avatar sksuryan
sksuryan - comment - 14 Mar 2021

EDIT: I mentioned the wrong issue.

@brianteeman my bad. ?

avatar sksuryan
sksuryan - comment - 14 Mar 2021

Closing because of latest merged commits in 4.0-dev. Will make a new PR with the rebased branch.

avatar sksuryan sksuryan - change - 14 Mar 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-03-14 14:11:46
Closed_By sksuryan
avatar sksuryan sksuryan - close - 14 Mar 2021

Add a Comment

Login with GitHub to post a comment