No Code Attached Yet bug
avatar brianteeman
brianteeman
14 Mar 2021

Bootstrap v2 had two classes (has-success and has-danger) that were changed in bootstrap 4 and removed in bootstrap 5 https://getbootstrap.com/docs/5.0/forms/validation/

From my understanding we can therefore remove the use of those classes in https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/js/fields/validate.es6.js and maybe other changes can be made as well. (valid/invalid??)

The scss may also need updates as a result. For example we dont need to define valid/invalid in both files

  • administrator\templates\atum\scss\blocks_form.scss
  • administrator\templates\atum\scss\vendor\bootstrap_form.scss

bonus is that we get much nicer styling
image
image

avatar brianteeman brianteeman - open - 14 Mar 2021
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Mar 2021
avatar himanshu007-creator
himanshu007-creator - comment - 14 Mar 2021

.has-danger to .is-invalid and .has-success to .is-valid
Should I work for this? @brianteeman

avatar Khanjan04
Khanjan04 - comment - 23 Mar 2021

Can I work on this issue right now? @brianteeman

avatar Khanjan04
Khanjan04 - comment - 24 Mar 2021

I have tried to solve this issue according to my understanding. This is the PR related to it #32832 Please have a look and let me know if any changes are required.

avatar richard67 richard67 - change - 24 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-24 12:20:11
Closed_By richard67
avatar richard67 richard67 - close - 24 Mar 2021
avatar richard67
richard67 - comment - 24 Mar 2021

Closing as having a pull request. Please test #32832 . Thanks in advance.

avatar drmenzelit
drmenzelit - comment - 26 Mar 2021

Reopening because PR was not complete

avatar drmenzelit drmenzelit - change - 26 Mar 2021
Status Closed New
Closed_Date 2021-03-24 12:20:11
Closed_By richard67
avatar drmenzelit drmenzelit - reopen - 26 Mar 2021
avatar brianteeman brianteeman - change - 24 Jun 2021
The description was changed
avatar brianteeman brianteeman - edited - 24 Jun 2021
avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: No Code Attached Yet bug
Removed: ?
avatar Hackwar Hackwar - labeled - 22 Feb 2023

Add a Comment

Login with GitHub to post a comment