[#32666] - Removed deprecated iframe attributes from com/mod_wrapper #32598
- Closed
- 29 Mar 2021
- Medium
- Build: staging
- # 32666
- Diff
- Megh05:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #32598.
Summary of Changes
Removed deprecated iframe attributes from 'components/com_wrapper/views/wrapper/tmpl/default.php' & 'modules/mod_wrapper/tmpl/default.php'
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_wrapper Modules |
Stop and think about this change for a moment. What are you trying to do and what are you actually doing. Where are the values coming from for the variables you are removing from the output? If this is the only place that those variables are used do you think that you should remove the variables as well.
I am extremely sorry for this silly mistake, I'll re-check the code again and implement it wisely.
Dont be sorry. We all make mistakes - I just did on my own pr.
I didnt want to give you the full answer but I hope I have asked enough questions for you to find it for yourself
Dont be sorry. We all make mistakes - I just did on my own pr.
I didnt want to give you the full answer but I hope I have asked enough questions for you to find it for yourself
Sure thing Sir... Thank You!
@Megh05 Another thing which is not right with this PR here is that the issue was for Joomla 4, and so the change should also be made for Joomla 4, which belongs to the 4.0-dev branch here, but this PR is for the staging branch, which belongs to Joomla 3.9.
Totally understood, Thank you sir for your guidance!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-29 06:18:15 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
?
|
||
Stop and think about this change for a moment. What are you trying to do and what are you actually doing. Where are the values coming from for the variables you are removing from the output? If this is the only place that those variables are used do you think that you should remove the variables as well.