? Pending

User tests: Successful: Unsuccessful:

avatar saumyasarkar11
saumyasarkar11
12 Mar 2021

Pull Request for Issue # .

Summary of Changes

Check for the emptiness of $urls on lines 98 and 132 has been removed since the variable $urls can never be empty.

Testing Instructions

Create an article and check whether it is properly displayed or not with its url.

Actual result BEFORE applying this Pull Request

Untitled

Expected result AFTER applying this Pull Request

Untitled

Documentation Changes Required

None

avatar saumyasarkar11 saumyasarkar11 - open - 12 Mar 2021
avatar saumyasarkar11 saumyasarkar11 - change - 12 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2021
Category Front End com_content
avatar drmenzelit
drmenzelit - comment - 12 Mar 2021

This change is not correct. $urls can be empty. You didn't tested using the URL fields on an article. In the screenshot you see the fields Link A, Link B and Link C, that are the URL fields:

grafik

avatar saumyasarkar11
saumyasarkar11 - comment - 12 Mar 2021

This change is not correct. $urls can be empty. You didn't tested using the URL fields on an article. In the screenshot you see the fields Link A, Link B and Link C, that are the URL fields:

grafik

Got it. Thanks for the feedback. Will look into it.

avatar saumyasarkar11 saumyasarkar11 - change - 12 Mar 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-03-12 08:54:18
Closed_By saumyasarkar11
Labels Added: ?
avatar saumyasarkar11 saumyasarkar11 - close - 12 Mar 2021

Add a Comment

Login with GitHub to post a comment