? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
11 Mar 2021

I apologize.
I believe that the name of the newly added attribute for the fields is not quite correct.
Calling it the parent class. This is logical, but it is not clear which parent it refers to.
At first glance, you might think that this is the parent of the field. But this is not the case.
After thinking about it, you might think that this is the parent of the control, but this is also not the case. Since the control itself is the target.
img-2021-03-09-13-35-32
#32488
The author @ciar4n of the attribute agreed to replace the attribute name.

avatar korenevskiy korenevskiy - open - 11 Mar 2021
avatar korenevskiy korenevskiy - change - 11 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2021
Category Layout Libraries
avatar ciar4n
ciar4n - comment - 11 Mar 2021

The author @ciar4n of the attribute agreed to replace the attribute name.

Not exactly true ? ... I just said I wasn't going to apply your suggestion to a PR that had already gone to RTC.

avatar korenevskiy
korenevskiy - comment - 11 Mar 2021

The author @ciar4n of the attribute agreed to replace the attribute name.

Not exactly true ? ... I just said I wasn't going to apply your suggestion to a PR that had already gone to RTC.

but you put a thumbs-up emoji there. ?

avatar ceford ceford - test_item - 12 Mar 2021 - Tested successfully
avatar ceford
ceford - comment - 12 Mar 2021

I have tested this item successfully on 6901dbc

I looked at the diff, applied the patch and searched for parentclass and controlclass. I think it is OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32645.

avatar dgrammatiko
dgrammatiko - comment - 12 Mar 2021

I think if you dislike the parentclass an alternative logical value could be containerclass and not controlclass.

avatar korenevskiy
korenevskiy - comment - 12 Mar 2021

I think if you dislike the parentclass an alternative logical value could be containerclass and not controlclass.

@dgrammatiko
I agree with you. I think Container class is an equivalent sentence. But there is one thing.
Let's look at the XML configuration.
Field <field name= "title" type= "text" label= "Title"/>
Please tell me this element is primarily a control, container or field?
Perhaps it also makes sense to consider the name fieldclass
I think choosing a name for this class is a very important thing, even if Joomla 5 comes out, the name of the attributes will remain for centuries. We must choose the name of this attribute responsibly.
Where to conduct a survey among developers to select
controlclass VS containerclass .
containerclass a good attribute name.
and caseclass another option.

avatar korenevskiy korenevskiy - change - 6 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2021
Category Layout Libraries Layout Libraries Front End Templates (site)
avatar korenevskiy korenevskiy - change - 9 Jun 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-06-09 13:43:41
Closed_By korenevskiy
avatar korenevskiy korenevskiy - close - 9 Jun 2021
avatar korenevskiy korenevskiy - change - 9 Jun 2021
Status Closed New
Closed_Date 2021-06-09 13:43:41
Closed_By korenevskiy
avatar korenevskiy korenevskiy - change - 9 Jun 2021
Status New Pending
avatar korenevskiy korenevskiy - reopen - 9 Jun 2021
avatar korenevskiy korenevskiy - change - 15 Aug 2021
Labels Added: ?
Removed: ?
avatar korenevskiy korenevskiy - change - 16 Aug 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2021
Category Layout Libraries Front End Templates (site) Administration com_content Layout Libraries Front End Templates (site)
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar korenevskiy korenevskiy - change - 1 Jul 2022
Labels Added: Conflicting Files ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2022
Category Layout Libraries Front End Templates (site) Administration com_content Layout Libraries Front End Templates (site)
avatar korenevskiy korenevskiy - change - 1 Jul 2022
Labels Added: ?
Removed: Conflicting Files ?
avatar korenevskiy korenevskiy - change - 27 Aug 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-08-27 14:05:36
Closed_By korenevskiy
avatar korenevskiy korenevskiy - close - 27 Aug 2022

Add a Comment

Login with GitHub to post a comment