Feeling Lucky
?
?
[#32634] - [4.0] fixes the long login page issue.
- Fixed in Code Base
- 11 Mar 2021
- Medium
- Build: 4.0-dev
- # 32634
- Diff
- sksuryan:long_login_page_fix
User tests: Successful: Unsuccessful:
This pull request is a fix for #32560 and #29119.
Summary of Changes
As was being discussed on the issue #32560, I did exactly what @infograf768 did, and as mentioned by @drmenzelit for changing the order, I removed order-0 class from side-wrapper div in login.php and added order: 0; for #side-wrapper in _login.scss.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
ChristineWk
- comment
- 10 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32634.
jwaisner
- comment
- 11 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32634.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 11 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32634.
Quy
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-11 16:20:20 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 11 Mar 2021
Thank you for your contribution!
1 pr fix 2 issues?
? First-time contributor