Thank you for your first PR in Joomla @sksuryan. @C-Lodder can you be so kind and explain our new contributor (GSoC student) what you mean with your comment? Thank you.

Thank you for your first PR in Joomla @sksuryan. @C-Lodder can you be so kind and explain our new contributor (GSoC student) what you mean with your comment? Thank you.

Thank you @drmenzelit, Glad to make my first PR to Joomla.

I can confirm that the svg logo has a transform="translate(10 0) scale(1.3)" defined... why? I have no idea...
But in the index.php from atum the logo is being inserted in an image tag and not as svg direct. Which way is better it is difficult to say, but we should be consistent.

for some reason, only this logo was being cut-off from all sides like this while rest images were fine but it is fine if I use it's source directly.

I realized that was because I was using img tag but since it's an svg I can directly import it and use it.

I can confirm that the svg logo has a transform="translate(10 0) scale(1.3)" defined... why? I have no idea...
But in the index.php from atum the logo is being inserted in an image tag and not as svg direct. Which way is better it is difficult to say, but we should be consistent.

Pushing new changes which should address this. It also changes px values in favor of rem.

I have tested this item ✅ successfully on 0543574

I have tested it successfully on Joomla 4.0.0-beta-8-dev.

An alternative PR #33100.

An alternative PR #33100.

This PR actually adds the same logo to Installation UI as in the Admin UI since the previous logo in the Installation UI was much bigger. This PR doesn't change anything in the Admin UI itself.

@sksuryan Do you really think someone will ever compare the logo sizes of the installation and the admin UI? To be honest, in my personal opinion this PR here is not really needed. But that's just my personal opinion, I don't have any right to decide ;-)

@richard67 I mean, an issue does exist for this

@richard67 consistency in branding is always good

@sksuryan Not really a major issue, and sometimes we close issues as won't fix. But as said, that's not only my decision.

consistency in branding is always good

@brianteeman Is the same brand, only different size, so not really inconsistent. And the PR adds another import of an SVG .. is that really worth the little benefit?

This has been fixed with PR #33100. Please install the latest version and confirm.

I am making no comment on how the code is changed ;)

If it was just an issue then closing as "wont fix" is fine and should be done much much much more often
But this is a PR.

If the PR works and meets standards etc then it should be considered.

if it has already been fixed elsewhere then of course it should be closed as there is nothing left to fix?

that issue is still present after merge of #33100 ?
anyway as per Conflicting files @sksuryan you should revisit your pr ;)

that issue is still present after merge of #33100 ?
anyway as per Conflicting files @sksuryan you should revisit your pr ;)

I'll take a look @alikon

Closing as this is no longer an issue. Thanks for the PR.