Thanks for the effort!

Unfortunately, I tested this unsuccessfully. This results in this error when viewing a category with 0 articles displayed:

0 - Call to a member function getPagination() on null

@AndySDH Will look at it later.

@joomdonation should we return empty array at category model when $limit == 0 ?

or return empty array on ListModel.php, because this issue can affect other core components.

Should we return empty array at category model when $limit == 0 ?

I have to look at it again but I think it is working like that for category model at the moment

return empty array on ListModel.php, because this issue can affect other core components

It is a backward-incompatible change, so we are not allowed to do that. Further more, in Joomla!, look like we want all records returned when no limit is set.

I think we only need change line 251 of components\com_content\models\category.php

from if ($limit >= 0)

to if ($limit > 0)

I think we only need change line 251 of components\com_content\models\category.php

from if ($limit >= 0)

to if ($limit > 0)

I don't think that's enough. It will cause no articles being displayed when access to a category from Articles - Categories module (with no menu items linked to categories or category view). Also, if we just change that, there are still unnecessary code executed ($model->setState commands) when we do not need to query database to get articles.

I will try to review code carefully later.

Correct me if i'm wrong. Your code is trying to resolve unlimited items on two cases:

1. Menu com_content, view=category and all settings are set to 0 item

• Your solution: don't call model->getItems() when limit <= 0
• My point: It's ok. And i found that the pagination still load and make query to get total. Is that ok?

2. You access com_content, view=category without any menu

• We can use this url to replicate : index.php?option=com_content&view=category&id={category_id}
• Your solution: set limit to value of global config list_limit
• My point: why don't we use global config of com_content in this case? May be this check no longer needed?

// Set limit for query. If list, use parameter. If blog, add blog parameters for limit.
if (($app->input->get('layout') === 'blog') || $params->get('layout_type') === 'blog')

2. Exactly, Category Blog has default settings, so it should fall back to that:

And if this was not the case, I don't think this is a "BC Change", this is a "Bug Fix" :D

1. Exactly, Category Blog has default settings, so it should fall back to that:

And if this was not the case, I don't think this is a "BC Change", this is a "Bug Fix" :D

I've found a mistake at my point. That you can change layout of category itself to Listing. In this case, the limit should be global config list_limit as @joomdonation did :).

But if category layout is blog, the limit should respect blog global config, otherwise the pagination will be wrong.

Why was this PR closed, @joomdonation @Quy ?

This is still an issue in Joomla 4.