[#32622] - Update default.php in mod_banners
- Fixed in Code Base
- 20 Apr 2021
- Medium
- Build: staging
- # 32622
- Diff
- DelPoint:patch-1
User tests: Successful: Unsuccessful:
Missing container element for $headerText (optional in banner module), which limits the header text's CSS styling. (While $footerText has a proper container element.)
Pull Request for Issue # .
Summary of Changes
Added div container element around $headerText (optional Header Text in banner module).
Testing Instructions
Nothing serious, just select 'HTML5' or 'none' style for module output, then check the output code of the page.
Actual result BEFORE applying this Pull Request
<div class="bannergroup">
Banner Header Text
<div class="banneritem">
...
Expected result AFTER applying this Pull Request
<div class="bannergroup">
<div class="bannerheader">
Banner Header Text
</div>
<div class="banneritem">
...
Documentation Changes Required
Add bannerheader class name and its description to this document (or to its newer variant, if exist - couldn't find one though): https://docs.joomla.org/CSS_Class_Names_Frontend_in_Version_1.6
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32622.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32622.
| Labels |
Added:
?
?
Removed: ? |
||
Merging thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-20 16:59:46 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item✅ successfully on 4789d13
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32622.