[#32579] - s/404/500
- Fixed in Code Base
- 15 Mar 2021
- Medium
- Build: staging
- # 32579
- Diff
- PhilETaylor:patch-77
User tests: Successful: Unsuccessful:
This is triggered If the path to the images folder is not a directory.
The error raised is not a HTTP 404 Page Not Found, this is factually incorrect, there is no "page" that is not found.
Its an InvalidArgumentException therefore it should be a HTTP 500 Internal Server Error, the error is internal, its not a page not found. Its an Error like JERROR_AN_ERROR_HAS_OCCURRED states. a 404 is not an error.
Prior to Joomla 3.9.25 you would get a more helpful message:
After 3.9.25 you get this which is less helpful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
@PhilETaylor
Pls don't don't laugh at me :-) tks.
Just for testing, I changed intentionally under media > options the path images to application. I know, that's wrong :-) Got Actual Result.
But: content > media is broken now. Which file should I load from a clean J 3.9.25? Under FTP, the images are there.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.
Solved now via Backend.
System > Global Configuration > Site > Media > Path to File Folder & to Images Folder > images.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.
@ChristineWk so was your test successful? Then please mark it in the issue tracker.
Shall not we use a similar code as in filesystem/folder.php error instead of a simple error has occured??
Text::sprintf('JLIB_FILESYSTEM_ERROR_PATH_IS_NOT_A_FOLDER_FOLDER', $path), Log::WARNING, 'jerror');
or is that a problem to display part of a path?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.
richard67
- | Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-15 10:12:14 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on 70d36a7
Tested successfully in 3.9.26-dev of 4 March.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32579.