[#32566] - update copyright year in ALL files
- Closed
- 2 Mar 2021
- Medium
- Build: staging
- # 32566
- Diff
- hans2103:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Changing the year in ALL files to meet the current year 2021.
Testing Instructions
-
open htaccess.txt
-
read the doc block at the top of the file
-
open PHP files
-
read the doc block at the top of the file
-
open .ini files
-
read the doc block at the top of the file
Actual result BEFORE applying this Pull Request
Copyright (C) 2005 - 2020 Open Source Matters. All rights reserved.
Expected result AFTER applying this Pull Request
Copyright (C) 2005 - 2021 Open Source Matters. All rights reserved.
Documentation Changes Required
| Status | New | ⇒ | Pending |
@brianteeman when viewing branch staging I can't confirm the removal of the end years. I do see the removal of the end years in 3.10.dev and up
The point is that EVERY file should have been updated to 2021 and @HLeithner should not have removed the bump script cea0be4
That's why it is always always always a bad idea to commit directly without review as it leads to silly little mistakes
This PR should not be accepted unless all files are updated. Makes zero sense to update one file
Challenge accepted
revert the bump script change and then run it/ job done
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | ⇒ | Repository Unit Tests Administration com_admin |
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-02 21:48:40 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
The reason we didn't made a copyright bump was that solving 4k+ merge conflicts between 3.9 and 3.10 is a waste of time. That's the reason why 3.9.24 was without year bump. If there a 3.9.26 really is necessary I will bump the year before release and solve the merge conflicts.
Thanks @hans2103 for the PR but the bump script does a good job normally.
The end years were all supposed to have been removed weren't they? @nibra