[#32558] - [4.0] Fix Batch Menu Items in 4.0 - Update default_batch_body.php
- Closed
- 2 Mar 2021
- Medium
- Build: 4.0-dev
- # 32558
- Diff
- particthistle:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #32375, but for Joomla 4 instance.
Summary of Changes
Issue resolved in "Fix batch menu items" #32380 was applied to staging, but also affects 4.0-dev, as mentioned by @infograf768 in this comment.
Changing the published option from $published to $this->state->get('filter.published') resolves it.
Problem identified during testing in Joomla 4 Beta 8 nightly build. Problem didn't appear to occur in Beta 6, but does occur in Beta 7 onwards.
Testing Instructions
- Access to Menus -> Main Menu
- Select some menu items, then press Batch button in the toolbar
- The dropdown for the Copy/Move option to reassign the parent for the batch selection of menu items should show a list of published menu items, but currently does not without the patch applied.
Actual result BEFORE applying this Pull Request
Before patch: On the popup you only see the Menu names, and no options to assign as parent.
Expected result AFTER applying this Pull Request
After patch: Published menu items are displayed to assign as parent items
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Exact. Closing. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-02 07:50:33 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Apologies - comes with having avoided testing J3 and only concentrating on J4. First time I've encountered an issue where it flows through both code bases.
As it's 3 weeks since #32380 was merged and the issue was still in J4, I mistakenly thought it had been missed vs needing to wait for the fix.
@particthistle The issue will be fixed when the changes in staging is merged into 4.0-dev, so this PR could be closed (no need for two separate PRs, one for staging and one for 4.0-dev).