[#32555] - [4.0] Hide disabled components in mod_submenu
- Fixed in Code Base
- 5 Mar 2021
- Medium
- Build: 4.0-dev
- # 32555
- Diff
- alikon:patch-81
User tests: Successful: Unsuccessful:
Pull Request for Issue #32456.
Summary of Changes
don't show items from disabled component in mod_submenu
Testing Instructions
see #32456.
Actual result BEFORE applying this Pull Request
see #32456.
Expected result AFTER applying this Pull Request
no items from disabled components are shown
alterrnative to #32539
let's see how many
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
btw, we have similar in mod_menu also
joomla-cms/administrator/modules/mod_menu/src/Menu/CssMenu.php
Lines 312 to 317 in fa6cc5d
so all should be good
| Title |
|
||||||
I have tested this item
Before applying patch, "Manage" list on System Dashboard had 9 items:
Extensions, Languages, Content Languages, Language Overrides, Content Security Policy, Plugins, Redirects, Site Modules, Administrator Modules
After applying patch, without turning off any components, some items disappeared:
Languages, Content Languages, Language Overrides
It seems these three Language related items are not following the same configuration as the other items in the list.
As Language component is a protected one, it can't be disabled, but I'm not sure why it's not otherwise appearing.
Aside from the Language items, the PR works as expected when I turned off either CSP or Redirects as two items available to disable in that dashboard module.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32555.
@particthistle I think the error here is not related to this PR. I don't understand how menu presets work, but someone familiar with that concept should check https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_menus/presets/system.xml#L127-L149 to see why element="com_language", not element="com_languages" (I think it is typos). One that issue is fixed, the error you reported here won't happen.
@particthistle I think the error here is not related to this PR. I don't understand how menu presets work, but someone familiar with that concept should check https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_menus/presets/system.xml#L127-L149 to see why element="com_language", not element="com_languages" (I think it is typos). One that issue is fixed, the error you reported here won't happen.
@joomdonation @particthistle Who wants to make a PR?
| Category | Modules Administration | ⇒ | Administration com_menus Modules |
better to do it in this pr imho
please test again
I have tested this item
All good this time around.
Glad it was something easy for you to resolve @alikon as I wouldn't have known where to start to fix that up.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32555.
I have tested this item
Tested successfully in Beta8-dev of 3 March in Wampserver 3.2.4 using PHP 8.0.2.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32555.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32555.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-05 12:38:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
LGTM. Nice work everyone!
this actually looks much better than #32539
because ComponentHelper already have a pre-loaded list of available components.