[#32550] - [4.0] Fixed menu params for front page item on installation
- Fixed in Code Base
- 10 Mar 2021
- Medium
- Build: 4.0-dev
- # 32550
- Diff
- Harmageddon:fix_installation_menu_params
User tests: Successful: Unsuccessful:
Pull Request for Issue #32493. Note: This is not an alternative to #32547 - both are necessary. #32547 for fixing the notice and another error, and this PR here for fixing the underlying cause.
Summary of Changes
The "home" menu item that is created on installation contains parameters from 3.x, and lacks parameters from 4.x. This PR fixes the installation SQL.
Testing Instructions
IMHO, this could be merged on code review. Testing instructions are a bit more complicated here.
- Install a clean 4.0-beta7 or nightly.
- Important: Don't edit the "home" menu item!
- Create 4 articles and set them as featured and published.
- Look at the home page. The articles should be displayed in a one-column layout.
- Update using a 4.0-beta7 or nightly update package.
- Look again at the home page.
Using the prebuilt packages for this PR, do a clean new installation and repeat steps 2-6.
Actual result BEFORE applying this Pull Request
Before the update, the "home" item displays articles in a one-column layout. After running an update, it displays them in three columns.
Expected result AFTER applying this Pull Request
Updating should not change the layout.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation |
| Labels |
Added:
?
|
||
| Category | SQL Installation | ⇒ | SQL Installation Postgresql |
@richard67 Of course, you're absolutely right. Thank you!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
I have tested this item
Tested successfully.
Have also followed up @infograf768 comment on #32525 to help @AndySDH update the relevant parameters in the sample data script to also avoid J3 parameters being included and J4 parameters being missed in what that PR does.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
show_associations should be added as it is a blog/featured parameter (Options).
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
@Harmageddon Could you check #32550 (comment) ? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
| Labels |
Added:
?
|
||
Sorry for the delayed response, I didn't have much time during the week.
Thank you @infograf768 for the suggestion! I added it to both files.
(fyi: sandk2)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32550.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-10 09:50:19 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
@Harmageddon And
installation/sql/postgresql/base.sqldoesn't need a fix? That seems strange to me.