? Success

User tests: Successful: Unsuccessful:

avatar PAlexcom
PAlexcom
7 Mar 2014

Updated all available Microdata Types/Properties and added the new ones
The types.json file is used by the JMicrodata library.

avatar PAlexcom PAlexcom - open - 7 Mar 2014
avatar Bakual
Bakual - comment - 7 Mar 2014

The file mode for libraries/joomla/microdata/microdata.php changed. That's probably not intended, right?

avatar PAlexcom
PAlexcom - comment - 8 Mar 2014

@Bakual Yeah, that's right. I've created a big mess... probably when merging from the upstream.
How can I solve this problem? If I will rebase the log history will that affect the Pull Request?
The only file changed that needs to be accepted is the types.json

avatar PAlexcom PAlexcom - change - 8 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-08 16:53:50
avatar PAlexcom PAlexcom - close - 8 Mar 2014
avatar PAlexcom PAlexcom - close - 8 Mar 2014
avatar Bakual
Bakual - comment - 9 Mar 2014

You could just change it back to the original value in this branch of your fork. That should do.

Add a Comment

Login with GitHub to post a comment