Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32547] - [4.0] Fixed empty blog class on update

? ? Pending

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
28 Feb 2021

Pull Request for Issue #32493 .

Summary of Changes

This fixes two things:

  1. A PHP notice that occurs under certain circumstances (see testing instructions).
  2. A || true that I used for debugging purposes in the making of #31570 and accidentally committed (can be merged on code review).

Testing Instructions

  1. Install a clean beta-7 or nightly version.
  2. Set error reporting to development or maximum, don't make any other changes.
  3. Immediately after installation, run an update using an update package.

To test the PR, please start again with a clean beta-7 or nightly and then use the update package from this PR. This PR has no effect when updating an already updated site.

Actual result BEFORE applying this Pull Request

If you use an unpatched beta-7 update package, you will see notices like in #32493.

Expected result AFTER applying this Pull Request

Using the update package from this PR (see at the bottom "Show all checks" - "Download"), the notices should no longer appear.

Documentation Changes Required

none

avatar Harmageddon Harmageddon - open - 28 Feb 2021
avatar Harmageddon Harmageddon - change - 28 Feb 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2021
Category ⇒ Administration com_admin
avatar Harmageddon Harmageddon - change - 28 Feb 2021
Title
…
Fixed empty blog class on update.
[4.0] Fixed empty blog class on update
avatar Harmageddon Harmageddon - edited - 28 Feb 2021
avatar Harmageddon Harmageddon - change - 28 Feb 2021
The description was changed
avatar Harmageddon Harmageddon - edited - 28 Feb 2021
avatar jsubri jsubri - test_item - 1 Mar 2021 - Tested successfully
avatar jsubri
jsubri - comment - 1 Mar 2021

I have tested this item ✅ successfully on 067bd89

The 2 warnings are gone after applying the patch.
Thank you

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

avatar chmst chmst - test_item - 1 Mar 2021 - Tested successfully
avatar chmst
chmst - comment - 1 Mar 2021

I have tested this item ✅ successfully on 067bd89

Tested on win10, php8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

avatar richard67 richard67 - change - 1 Mar 2021
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 1 Mar 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32547.

avatar wilsonge wilsonge - close - 1 Mar 2021
avatar wilsonge wilsonge - merge - 1 Mar 2021
avatar wilsonge wilsonge - change - 1 Mar 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-03-01 18:00:27
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 1 Mar 2021

Thanks!

And oops - really should have spotted that || true on code review

Add a Comment

Login with GitHub to post a comment