Feeling Lucky
?
?
[#32538] - [4.0] Code Simplify For Article view
- Fixed in Code Base
- 10 Mar 2021
- Medium
- Build: 4.0-dev
- # 32538
- Diff
- joomdonation:article_view_code_simplify
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR improves code of Article view abit:
- Use a standard way to check if the current active menu item is linked to article (same with code on other places, not use strpos like before.
- Remove repeating code (the case for there is no active menu item and active menu item is not linked to article is the same, can be moved into single else block)
Testing Instructions
- Apply patch
- Access to an article on the site. Make sure it is still working as before
Alternative, code review should be enough.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
ceford
- comment
- 10 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32538.
joomdonation
- comment
- 10 Mar 2021
Could someone mark this PR as RTC so that it could be merged if it is possible? There is still bad code in the view and I want to work on further clean up after this one get merged. Thanks !
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 10 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32538.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-10 19:17:20 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 22f97ef
Tested successfully in Beta8-dev of 27 February using PHP 8.0.2.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32538.