Joomla! Issue Tracker | Joomla! CMS #32525 - [4.0] Updating all views to use H1 for Component Title when Menu Title is hidden

? ? ?

Fixed in Code Base
17 Apr 2021
Medium
Build: 4.0-dev
# 32525
Diff
AndySDH:patch-17

Pending

User tests: Successful: Unsuccessful:

AndySDH
26 Feb 2021

Follow-up Pull Request after #32448

Summary of Changes

After updating the article view with the above-mentioned PR, this PR updates all the other views as well to show the component title as H1 when the Menu Title is hidden.

In particular this updates the following views:

Contact Default
Content Category Default
Content Category Blog
Newsfeed Category
Tag Default
Tag List

In addition, when doing this, I stumbled upon an unused page_subheading param that was present in the 'featured' views and the 'category blog' views. This looks to be an outdated and out of place parameter that was present just in those two views and nowhere else. I don't think nobody has even ever used it.

So this also addresses issue #29586, removing the page_subheading parameter in those views, making them consistent with all the other views as well.

Actual result BEFORE applying this Pull Request

Components title is H2.

Expected result AFTER applying this Pull Request

Components title is H1 when Menu Title is hidden.

6810565 26 Feb 2021

Update category_default.php

19babc7 26 Feb 2021

Update list.php

6fdf048 26 Feb 2021

Update default.php

5ec7112 26 Feb 2021

Update default.php

143e9ca 26 Feb 2021

Remove unused page_subheading param

2179db3 26 Feb 2021

Remove unused page_subheading

9e18baa 26 Feb 2021

Update default.xml

d195c11 26 Feb 2021

Remove page_subheading unused param

ae3075b 26 Feb 2021

Update default.xml

17052fd 26 Feb 2021

remove page_subheading unused param

595610b 26 Feb 2021

remove page_subheading unused param

f32d03b 26 Feb 2021

remove page_subheading unused param

f7a9cf4 26 Feb 2021

Update blog.php

73d550b 26 Feb 2021

Update default.php

AndySDH - open - 26 Feb 2021

AndySDH - change - 26 Feb 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 26 Feb 2021

Category

⇒

Front End com_contact com_content com_newsfeeds com_tags Layout Plugins

AndySDH - change - 26 Feb 2021

The description was changed

AndySDH - edited - 26 Feb 2021

richard67 - comment - 26 Feb 2021

@AndySDH So this PR solves that issue #29586 ?

AndySDH - comment - 26 Feb 2021

Please test @laoneo @bembelimen @brianteeman @simbus82 @Quy
Thanks!

AndySDH - comment - 26 Feb 2021

@AndySDH So this PR solves that issue #29586 ?

Yeah, addresses that too as explained above. I opted to just remove the parameter as it was widely inconsistent and out of place (especially in the blog view). I don't think nobody has even ever used it.

richard67 - comment - 26 Feb 2021

Yeah, addresses that too as explained above :)

@AndySDH Yes, but to address and to solve it is not 100 % the same thing, so I asked to be sure. Thanks for reporting back, and thanks for your contributions so far, it's really appreciated.

AndySDH - change - 26 Feb 2021

The description was changed

AndySDH - edited - 26 Feb 2021

9fd8a89 26 Feb 2021

Update components/com_tags/src/View/Tag/HtmlView.php

AndySDH - change - 26 Feb 2021

Labels

Added: ?

AndySDH - change - 26 Feb 2021

Title

…

Updating all views to use H1 for Component Title when Menu Title hidden

[4.0] Updating all views to use H1 for Component Title when Menu Title hidden

AndySDH - edited - 26 Feb 2021

AndySDH - change - 26 Feb 2021

Title

…

[4.0] Updating all views to use H1 for Component Title when Menu Title hidden

[4.0] Updating all views to use H1 for Component Title when Menu Title is hidden

AndySDH - edited - 26 Feb 2021

0494fd7 26 Feb 2021

Update joomla.ini

joomla-cms-bot - change - 26 Feb 2021

Category

Front End com_contact com_content com_newsfeeds com_tags Layout Plugins

⇒

Front End com_contact com_content com_newsfeeds com_tags Language & Strings Layout Plugins

fe926ab 26 Feb 2021

Update joomla.ini

AndySDH - change - 26 Feb 2021

Labels

Added: ?

joomla-cms-bot - change - 26 Feb 2021

Category

Front End com_contact com_content com_newsfeeds com_tags Layout Plugins Language & Strings

⇒

Administration Language & Strings Front End com_contact com_content com_newsfeeds com_tags Layout Plugins

970c03d 26 Feb 2021

Update joomla.ini

himanshu007-creator - test_item - 28 Feb 2021 - Tested successfully

himanshu007-creator - comment - 28 Feb 2021

I have tested this item ✅ successfully on 970c03d

I opened the Contact default view. Before applying the patch title was having h2 tag, after patch, it was h1.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

particthistle - test_item - 1 Mar 2021 - Tested unsuccessfully

particthistle - comment - 1 Mar 2021

I have tested this item ? unsuccessfully on 970c03d

See next comment and review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

particthistle - comment - 1 Mar 2021

I have tested this item ? unsuccessfully on 970c03d

See next comment and review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

infograf768 - comment - 1 Mar 2021

This one also needs changes:

joomla-cms/plugins/sampledata/multilang/multilang.php

Lines 856 to 869 in 90ab8c0

    
           'params'       => '{"layout_type":"blog","show_category_heading_title_text":"","show_category_title":"",' 
        
           	. '"show_description":"","show_description_image":"","maxLevel":"","show_empty_categories":"",' 
        
           	. '"show_no_articles":"","show_subcat_desc":"","show_cat_num_articles":"","show_cat_tags":"",' 
        
           	. '"page_subheading":"","num_leading_articles":"1","num_intro_articles":"3",' 
        
           	. '"num_links":"0","show_subcategory_content":"","orderby_pri":"",' 
        
           	. '"orderby_sec":"front","order_date":"","show_pagination":"2","show_pagination_results":"1",' 
        
           	. '"show_featured":"","show_title":"","link_titles":"","show_intro":"","info_block_position":"",' 
        
           	. '"info_block_show_title":"","show_category":"","link_category":"","show_parent_category":"",' 
        
           	. '"link_parent_category":"","show_associations":"","show_author":"","link_author":"",' 
        
           	. '"show_create_date":"","show_modify_date":"","show_publish_date":"","show_item_navigation":"",' 
        
           	. '"show_vote":"","show_readmore":"","show_readmore_title":"","show_hits":"","show_tags":"",' 
        
           	. '"show_noauth":"","show_feed_link":"1","feed_summary":"","menu-anchor_title":"","menu-anchor_css":"",' 
        
           	. '"menu_image":"","menu_image_css":"","menu_text":1,"menu_show":1,"page_title":"","show_page_heading":"1",' 
        
           	. '"page_heading":"","pageclass_sfx":"","menu-meta_description":"","robots":""}',

would also be modified to include the changes as done in #32550

d80ac3b 1 Mar 2021

Fix syntax error, whoops

AndySDH - comment - 1 Mar 2021

@AndySDH - working through testing all the scenarios (@himanshu007-creator - will chat in Glip about improving the level of detail for your testing) and found a syntax error that breaks the Blog Category Layout when the patch is applied.

Aside from that, all the other scenarios look to have worked correctly, so will be able to retest quickly when this has been fixed up as I've got all the menu items for the different scenarios saved and ready to go.

Whoops, sorry, thanks for reporting this! It's now fixed.

How did the auto-check not automatically spot this?

particthistle - comment - 1 Mar 2021

@AndySDH, take a look at @infograf768 suggest change needed for the sample data.

#32550 is being worked on concurrently, but it's taking care of the default install. The Sample Data has the same problem that PR is looking to fix, which is that the sample data has J3 parameters not J4 parameters. Just going to see if I can work out what needs to go in there quickly to speed up the change for you.

Once that's also fixed I'll then retest also with a new install + sample data install.

particthistle - comment - 1 Mar 2021

Changes to match up #32550. Part 2.

It stopped letting me add reviews to the code after line 862 for some reason. There's one more line needing adjustment to match up the changes outlined in #32550.

Line 864 - remove show_associations parameter: New line:
. '"link_parent_category":"","show_author":"","link_author":"",'

@AndySDH Ignore this per @infograf768 comment below.

infograf768 - comment - 2 Mar 2021

show_associations should stay as it is a blog parameter (Options).

AndySDH - comment - 3 Mar 2021

Thanks for the feedback, I'll wait for #32550 to be finalized and merged, and once that's merged, I'll make sure to have the same version of those files in this PR as well.

ceford - comment - 10 Mar 2021

#32550 is marked as merged - so is this ready for testing?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

richard67 - comment - 10 Mar 2021

@ceford I think maybe @AndySDH wants to update his branch first to latest 4.0-dev so it contains the changes from the merged PR, too. Let's see what he replies.

4c854a7 10 Mar 2021

Update base.sql

AndySDH - change - 10 Mar 2021

Labels

Added: ?

joomla-cms-bot - change - 10 Mar 2021

Category

Front End com_contact com_content com_newsfeeds com_tags Layout Plugins Language & Strings Administration

⇒

Administration Language & Strings Front End com_contact com_content com_newsfeeds com_tags SQL Installation Layout Plugins

b8c4297 10 Mar 2021

Update base.sql

joomla-cms-bot - change - 10 Mar 2021

Category

Front End com_contact com_content com_newsfeeds com_tags Layout Plugins Language & Strings Administration SQL Installation

⇒

Administration Language & Strings Front End com_contact com_content com_newsfeeds com_tags SQL Installation Postgresql Layout Plugins

0f22848 10 Mar 2021

Merge branch '4.0-dev' into patch-17

AndySDH - comment - 10 Mar 2021

Resolved conflicts with #32550 :)

particthistle - test_item - 15 Mar 2021 - Tested unsuccessfully

particthistle - comment - 15 Mar 2021

I have tested this item ? unsuccessfully on 0f22848

1. Syntax error with Blog Category Layout fixed from previous test, so this part was successful.

Additional changes were suggested for plugins/sampledata/multilang/multilang.php but have not been applied, so the parameters don't match #32550.

#32525 (comment) - Add . '"blog_class_leading":"","blog_class":"",' before line 859.
#32525 (comment) - Add "link_intro_image":"", at 860
#32525 (comment) - Add "article_layout":"_:default", at 862

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

AndySDH - change - 15 Mar 2021

Labels

Removed: ?

e94a87a 15 Mar 2021

Update multilang.php

AndySDH - comment - 15 Mar 2021

@particthistle Done, thanks!

particthistle - test_item - 16 Mar 2021 - Tested successfully

particthistle - comment - 16 Mar 2021

I have tested this item ✅ successfully on e94a87a

Thanks @AndySDH

H1 settings all working.
Changes to related items identified in the multi-language sample data identified in #32550 also now applying successfully.
_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

chmst - comment - 21 Mar 2021

Concerning subheading: It was used in 3.9 https://issues.joomla.org/tracker/joomla-cms/30422

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

AndySDH - comment - 21 Mar 2021

Concerning subheading: It was used in 3.9 https://issues.joomla.org/tracker/joomla-cms/30422

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.

I'm aware but it was used present only in 1 view (2 if you count Featured view), and absent in all the others. It was wildly inconsistent and I felt it served not much of a purpose. So I thought it made it sense to clean it up and remove it.

particthistle - comment - 22 Mar 2021

Subheading removal: Should it go ahead (I don't know anyone using it, but I'm sure there may be) do we just need to make sure it's listed here: https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4

If so, add Documentation Required tag for follow up.

himanshu007-creator - test_item - 17 Apr 2021 - Tested successfully

himanshu007-creator - comment - 17 Apr 2021

I have tested this item ✅ successfully on e94a87a

Tested the behavior on all mentioned categories. Thanks @particthistle for helping out earlier.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

06842c5 17 Apr 2021

Merge branch '4.0-dev' into patch-17

richard67 - alter_testresult - 17 Apr 2021 - particthistle: Tested successfully

richard67 - alter_testresult - 17 Apr 2021 - himanshu007-creator: Tested successfully

richard67 - comment - 17 Apr 2021

I've allowed myself to solve the merged conflict and restored the previous test results because the merge after that for resolving the merge conflict was only a code style change.

richard67 - change - 17 Apr 2021

Status

Pending

⇒

Ready to Commit

richard67 - comment - 17 Apr 2021

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32525.}

AndySDH - comment - 17 Apr 2021

Thanks @richard67

chmst - change - 17 Apr 2021

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2021-04-17 15:19:07
Closed_By		⇒	chmst
Labels	Added: ?

chmst - close - 17 Apr 2021

chmst - merge - 17 Apr 2021

chmst - comment - 17 Apr 2021

Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#32525] - [4.0] Updating all views to use H1 for Component Title when Menu Title is hidden

Summary of Changes

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Add a Comment

	'params' => '{"layout_type":"blog","show_category_heading_title_text":"","show_category_title":"",'
	. '"show_description":"","show_description_image":"","maxLevel":"","show_empty_categories":"",'
	. '"show_no_articles":"","show_subcat_desc":"","show_cat_num_articles":"","show_cat_tags":"",'
	. '"page_subheading":"","num_leading_articles":"1","num_intro_articles":"3",'
	. '"num_links":"0","show_subcategory_content":"","orderby_pri":"",'
	. '"orderby_sec":"front","order_date":"","show_pagination":"2","show_pagination_results":"1",'
	. '"show_featured":"","show_title":"","link_titles":"","show_intro":"","info_block_position":"",'
	. '"info_block_show_title":"","show_category":"","link_category":"","show_parent_category":"",'
	. '"link_parent_category":"","show_associations":"","show_author":"","link_author":"",'
	. '"show_create_date":"","show_modify_date":"","show_publish_date":"","show_item_navigation":"",'
	. '"show_vote":"","show_readmore":"","show_readmore_title":"","show_hits":"","show_tags":"",'
	. '"show_noauth":"","show_feed_link":"1","feed_summary":"","menu-anchor_title":"","menu-anchor_css":"",'
	. '"menu_image":"","menu_image_css":"","menu_text":1,"menu_show":1,"page_title":"","show_page_heading":"1",'
	. '"page_heading":"","pageclass_sfx":"","menu-meta_description":"","robots":""}',