Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
7 Mar 2014

This is PR #1841 updated with the current staging branch to assist with testing. I make no assurances on the code's functionality; all I've done is merged up the current code base and resolved any merge conflicts that came up.

avatar mbabker mbabker - open - 7 Mar 2014
avatar mbabker mbabker - change - 7 Mar 2014
Labels Added: ? ?
avatar phproberto
phproberto - comment - 12 Mar 2014

IMO we should avoid to create more useless configuration params. Microdata should be on by default. If you don't like it you can override the templates.

Same for everything related to enable microdata (com_contact config parameter and so).

avatar PAlexcom
PAlexcom - comment - 18 Mar 2014

I've created a more ordered Pull Request, please take a look here #3330

avatar parthlawate
parthlawate - comment - 19 Mar 2014

Working well. Tested as per instructions at #3330 for Joomla Content Article for Author, Content type & Rating semantic data.

avatar chiaraaliotta
chiaraaliotta - comment - 19 Mar 2014

Tried the patch and it works well on article. Get excited and tried on contact page, but it is not working. Was it thought just for articles?

avatar brianteeman
brianteeman - comment - 19 Mar 2014

@chiaraaliotta according to the files changed then yes it should apply to contacts as well

avatar chiaraaliotta
chiaraaliotta - comment - 19 Mar 2014

I think I found a bug: the feature is not obeying the configuration on the contact item level.
Steps to reproduce the bug:
1) Set the global configuration to enable microdata
2) Set the microdata option on the contact component level to global
3) Set the microdata option on the specific contact item to global as well

In this case the microdata is not showing. However, if you explicitly enable the option on the item level, it works.
So this is where the global configuration is not obeying on the item level.

avatar PAlexcom
PAlexcom - comment - 22 Mar 2014

@chiaraaliotta Could you please test this PR #3330 , it's easier to add one piece at the time, thanks.

avatar Bakual Bakual - close - 4 Jun 2014
avatar Bakual
Bakual - comment - 4 Jun 2014

Closing this PR as it's against an old branch and we merged a different approach for now.
Alex will do a new PR during his GSoC project.

avatar Bakual Bakual - change - 4 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-04 21:08:13
avatar Bakual Bakual - close - 4 Jun 2014

Add a Comment

Login with GitHub to post a comment